Version update for external libraries and bumping up versions for next release #5777
Conversation
srnagar
requested review from
alzimmermsft,
conniey,
g2vinay,
gapra-msft,
hemanttanwar,
jaschrep-msft,
jianghaolu,
JonathanGiles,
joshfree,
mssfang,
rickle-msft,
samvaity and
sima-zhu
as code owners
|
@g2vinay why does key vault need commons codec? |
|
/check-enforcer evaluate |
| <relativePath>../../../pom.client.xml</relativePath> | ||
| </parent> | ||
|
|
||
| <groupId>com.azure</groupId> | ||
| <artifactId>azure-core-tracing-opencensus</artifactId> | ||
| <version>1.0.0-preview.3</version> | ||
| <version>1.0.0-preview.4</version> |
There was a problem hiding this comment.
wait for this to be released, before merging.
There was a problem hiding this comment.
Yes, I will wait until all releases are done before merging this.
There was a problem hiding this comment.
Yes, I will wait until all releases are done.
| @@ -115,8 +115,8 @@ | |||
| <slf4j-log4j12.version>1.7.0</slf4j-log4j12.version> | |||
| <reactor-core.version>3.3.0.RELEASE</reactor-core.version> | |||
| <reactor-netty.version>0.9.0.RELEASE</reactor-netty.version> | |||
| <netty.version>4.1.39.Final</netty.version> | |||
| <okhttp.version>4.1.0</okhttp.version> | |||
| <netty.version>4.1.42.Final</netty.version> | |||
There was a problem hiding this comment.
The version of reactor-core we're using is 0.9.0-RELEASE which depends on 4.1.39.Final version of Netty. I'm not sure about any issue with we using a version of netty different than reactor-core depends on.
There was a problem hiding this comment.
It's a minor version upgrade and their release notes mention that 41, 42 are bug-fix releases with performance improvements.
There's at least one bug that was reported by a customer and fixed in 41.Final release . So, I would prefer to upgrade unless we find issues with 42.Final that's not in 39.Final.
https://netty.io/news/2019/09/12/4-1-41-Final.html
https://netty.io/news/2019/09/25/4-1-42-Final.html
|
cc @JimSuplizio |
|
Looks fine.
Currently, we are using Base64 from commons-codec for encode/decode puproses. |
|
Closing this PR in favor of #5795. @JimSuplizio is working on a tool to upgrade client library versions. So, the other PR will focus on upgrading only the external dependency versions. |
azure-core
azure-core-amqp
azure-core-http-netty
azure-core-http-okhttp
azure-core-test
azure-data-appconfiguration
No external dependencies.
azure-messaging-eventhubs
No external dependencies.
azure-message-eventhubs-checkpointstore-blob
No external dependencies.
azure-identity
azure-keyvault-certificates
azure-keyvault-keys
azure-keyvault-secrets
azure-storage-blob
azure-storage-blob-batch
azure-storage-blob-cryptography
No external dependencies.
azure-storage-common
azure-storage-file
azure-storage-file-datalake
azure-storage-queue
No external dependencies.
azure-storage-queue-cryptography
No external dependencies.
Fixes #5743