-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Metrics Filtering Part 4: Filtering For Metrics Charts #43323
Conversation
...pentelemetry/autoconfigure/implementation/quickpulse/filtering/DerivedMetricProjections.java
Outdated
Show resolved
Hide resolved
...pentelemetry/autoconfigure/implementation/quickpulse/filtering/DerivedMetricProjections.java
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps in another PR it may be worth to add logs at the TRACE or DEBUG level to understand filtering and derived metrics behaviors from a user application.
...etry/autoconfigure/implementation/quickpulse/filteringTest/DerivedMetricProjectionsTest.java
Outdated
Show resolved
Hide resolved
...etry/autoconfigure/implementation/quickpulse/filteringTest/DerivedMetricProjectionsTest.java
Outdated
Show resolved
Hide resolved
...etry/autoconfigure/implementation/quickpulse/filteringTest/DerivedMetricProjectionsTest.java
Outdated
Show resolved
Hide resolved
@jeanbisutti @trask Seeing this & noting that the writes/reads are all inside synchronized blocks, I am tempted to change count/aggregation inside of DerivedMetricAggregation class be just long and double, as opposed to AtomicLong/AtomicDouble. What do you think about this? |
...pentelemetry/autoconfigure/implementation/quickpulse/filtering/DerivedMetricProjections.java
Outdated
Show resolved
Hide resolved
...onitor/opentelemetry/autoconfigure/implementation/quickpulse/filtering/CustomDimensions.java
Outdated
Show resolved
Hide resolved
...pentelemetry/autoconfigure/implementation/quickpulse/filtering/DerivedMetricAggregation.java
Outdated
Show resolved
Hide resolved
...pentelemetry/autoconfigure/implementation/quickpulse/filtering/DerivedMetricAggregation.java
Show resolved
Hide resolved
...pentelemetry/autoconfigure/implementation/quickpulse/filtering/DerivedMetricProjections.java
Outdated
Show resolved
Hide resolved
...pentelemetry/autoconfigure/implementation/quickpulse/filtering/DerivedMetricProjections.java
Show resolved
Hide resolved
/check-enforcer override |
Description
Above changes enable e2e filtering for metrics charts.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines