Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Metrics Filtering Part 3: Filtering For Documents, with support for Trace Document filtering #43289

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

harsimar
Copy link
Member

@harsimar harsimar commented Dec 7, 2024

Description

Adds filtering for documents & honors the default documents filtering config. Previously, this code did not take into account traces as they were not part of the default metrics emitted. Now, the data collector also processes traces for documents filtering (A user can ask to filter documents related to Traces in the UI).

Spec references:

Added a few test cases + did some manual testing to see E2E behavior in the UI.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the OpenTelemetry OpenTelemetry instrumentation label Dec 7, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@harsimar harsimar marked this pull request as ready for review December 11, 2024 01:14
@harsimar
Copy link
Member Author

/check-enforcer override

@harsimar harsimar merged commit 1011b4d into main Dec 11, 2024
21 of 24 checks passed
@harsimar harsimar deleted the harskaur/docsFilterWithTraces branch December 11, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants