Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support url.query #39133

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Support url.query #39133

merged 2 commits into from
Mar 11, 2024

Conversation

trask
Copy link
Member

@trask trask commented Mar 8, 2024 •
edited
Loading

@github-actions github-actions bot added the OpenTelemetry OpenTelemetry instrumentation label Mar 8, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@trask trask changed the title Support url.query and url.fragment Support url.query Mar 8, 2024
@trask trask changed the title Support url.query Support url.query Mar 8, 2024
@trask trask marked this pull request as ready for review March 8, 2024 04:24
jeanbisutti
jeanbisutti approved these changes Mar 8, 2024
View reviewed changes
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
}
if (query != null) {
len += query.length() + 1; // including the query separator "?"
}
Copy link
Contributor

@jeanbisutti jeanbisutti Mar 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract method from line 656 to line 662 with a computeFullPathLength(...) method name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sort of like to be able to see the corresponding ifs here and below when appending

@heyams heyams merged commit 21e4d0f into Azure:main Mar 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@heyams heyams heyams approved these changes

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

Assignees
No one assigned
Labels
OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trask @azure-sdk @jeanbisutti @heyams