-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set skipPublishDocMs to true for packages which do not build docs #36385
Conversation
Just need an ack from cosmos (@kushagraThapar), mgmt (@weidongxu-microsoft), and personalizer (@sharathmalladi) |
Thanks Josh. Hi Daniel, does voiceservices and storagemover there because the service was deprecated? I am OK if service of them does not want they get to MsDoc. |
@weidongxu-microsoft -- From notes in our
Generally speaking, to make these work in the docs build a new version would need to be released which addresses these issues. |
Thanks @danieljurek. I am OK for the "resourcemanager" packages, if they currently fails. Is there any way we can test if a new release of them would pass the doc build? (local run of doc build? some pipeline maybe run from dev branch?) Reason is that there seems nothing special from storagemover or voiceservices. And both lib is fully generated by tool, which is used for other 100+ libs as well. (Maybe the problem is from Javadoc in the code) follow-up issue logged #36646 (label: MQ) |
@weidongxu-microsoft -- Sent email with instructions. |
I spoke with @kushagraThapar -- this package is intended to be documented so no changes to the |
Spoke with @alzimmermsft, the test failures in the |
/check-enforcer override |
You are on this PR review because you are a CODEOWNER reviewer. Please have a look at your service and package and let me know if you have concerns about skipping building docs.ms documentation for the following excluded packages.
The following packages do not build docs. This encodes the fact that those packages are not intended to be documented (as opposed to filtering by our validation heuristics).
Impacted packages:
sdk/cosmosazure-cosmos-test(removed after speaking with @kushagraThapar)