Setting the IndexingPolicy #19540
Merged
Setting the IndexingPolicy #19540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarathavale
requested review from
FabianMeiswinkel,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
Cosmos
customer-reported
|
Thank you for your contribution amarathavale! We will review the pull request and get back to you soon. |
|
Note: This PR can/should be merged before #19515 for a couple of reasons: this change is more urgent, and I can handle the merge conflict in the other one after this is committed. |
.../src/main/java/com/azure/cosmos/benchmark/linkedin/data/InvitationsCollectionAttributes.java
Outdated
Show resolved
Hide resolved
moderakh
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Question - "Refactored the existing implementation to support additional 'entities'. Like Invitations, entities such as UserGeneratedContent (where we use composite indexes) have a different document structure." -> Are we creating another set up documents for this entities along with invitation. So if we load 100 document , in BE it will be 100(invitation)+100(entities)
...smos-benchmark/src/main/java/com/azure/cosmos/benchmark/linkedin/DataGenerationIterator.java
Outdated
Show resolved
Hide resolved
simplynaveen20
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this change, the indexingPolicy is set to use the same strategy that we use for our production workloads: Index only the id and partitioningKey field for this collection (there is another use-case where we will validate the composite indexes; but in another change)
Validated this change by running the java cli command, and you can see the indexingPolicy:
Additional changes in here:
Validated these 2 items by running it locally, and verifying the NotFound count is 0.
-- Meters ----------------------------------------------------------------------
GET ctlWorkloadInvitations Document NotFound Operations
count = 0
...
GET ctlWorkloadInvitations Successful Operations
count = 132975
mean rate = 237.10 events/second
GET ctlWorkloadInvitations Unsuccessful Operations
count = 0
...
-- Timers ----------------------------------------------------------------------
GET ctlWorkloadInvitations Latency
count = 132975
...