Skip to content

Commit

Permalink
Fix error in update_version script since files.txt is removed.
Browse files Browse the repository at this point in the history
  • Loading branch information
conniey committed Jan 3, 2020
1 parent 8abb227 commit ebcee09
Showing 1 changed file with 0 additions and 20 deletions.
20 changes: 0 additions & 20 deletions eng/versioning/update_versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,26 +148,6 @@ def update_versions_all(update_type, build_type, target_file, skip_readme):
if (file_name.endswith('.md') and not skip_readme) or (file_name.startswith('pom.') and file_name.endswith('.xml')):
update_versions(version_map, file_path)

# This is a temporary stop gap to deal with versions hard coded in java files.
# Everything within the begin/end tags below can be deleted once
# https://github.com/Azure/azure-sdk-for-java/issues/3141 has been fixed.
# version_*_java_files.txt
# BEGIN:Versions_in_java_files
if not target_file and BuildType.none != build_type:
# the good thing here is that the java files only contain library versions, not
# external versions
version_java_file = os.path.normpath('eng/versioning/version_' + build_type.name + '_java_files.txt')
with open(version_java_file) as f:
for raw_line in f:
java_file_to_update = raw_line.strip()
if not java_file_to_update or java_file_to_update.startswith('#'):
continue
if os.path.isfile(java_file_to_update):
update_versions(version_map, java_file_to_update)
else:
raise FileNotFoundError(errno.ENOENT, os.strerror(errno.ENOENT), java_file_to_update)
# END:Versions_in_java_files

def main():
parser = argparse.ArgumentParser(description='Replace version numbers in poms and READMEs.')
parser.add_argument('--update-type', '--ut', type=UpdateType, choices=list(UpdateType))
Expand Down

0 comments on commit ebcee09

Please sign in to comment.