simplify

Azure · Aug 2, 2024 · 4512672 · 4512672
1 parent fd58b9b
commit 4512672
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 122 deletions.
diff --git a/...src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java b/...src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
@@ -6,7 +6,6 @@
 import com.azure.monitor.opentelemetry.exporter.implementation.builders.AbstractTelemetryBuilder;
 import com.azure.monitor.opentelemetry.exporter.implementation.builders.ExceptionDetailBuilder;
 import com.azure.monitor.opentelemetry.exporter.implementation.builders.ExceptionTelemetryBuilder;
-import com.azure.monitor.opentelemetry.exporter.implementation.builders.Exceptions;
 import com.azure.monitor.opentelemetry.exporter.implementation.builders.MessageTelemetryBuilder;
 import com.azure.monitor.opentelemetry.exporter.implementation.builders.RemoteDependencyTelemetryBuilder;
 import com.azure.monitor.opentelemetry.exporter.implementation.builders.RequestTelemetryBuilder;
@@ -37,6 +36,7 @@
 
 import static com.azure.monitor.opentelemetry.exporter.implementation.MappingsBuilder.MappingType.SPAN;
 import static java.util.Arrays.asList;
+import static java.util.Collections.singletonList;
 import static java.util.concurrent.TimeUnit.NANOSECONDS;
 import static java.util.concurrent.TimeUnit.SECONDS;
 
@@ -849,17 +849,17 @@ private TelemetryItem createExceptionTelemetryItem(
     }
 
     static void setExceptions(String stack, Attributes attributes, ExceptionTelemetryBuilder telemetryBuilder) {
-        List<ExceptionDetailBuilder> builders = Exceptions.minimalParse(stack);
-        ExceptionDetailBuilder exceptionDetailBuilder = builders.get(0);
+        ExceptionDetailBuilder builder = new ExceptionDetailBuilder();
         String type = attributes.get(SemanticAttributes.EXCEPTION_TYPE);
         if (type != null && !type.isEmpty()) {
-            exceptionDetailBuilder.setTypeName(type);
+            builder.setTypeName(type);
         }
         String message = attributes.get(SemanticAttributes.EXCEPTION_MESSAGE);
         if (message != null && !message.isEmpty()) {
-            exceptionDetailBuilder.setMessage(message);
+            builder.setMessage(message);
         }
-        telemetryBuilder.setExceptions(builders);
+        builder.setStack(stack);
+        telemetryBuilder.setExceptions(singletonList(builder));
     }
 
 

diff --git a/...ain/java/com/azure/monitor/opentelemetry/exporter/implementation/builders/Exceptions.java b/...ain/java/com/azure/monitor/opentelemetry/exporter/implementation/builders/Exceptions.java
diff --git a/...st/java/com/azure/monitor/opentelemetry/exporter/implementation/utils/ExceptionsTest.java b/...st/java/com/azure/monitor/opentelemetry/exporter/implementation/utils/ExceptionsTest.java