Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure CMakeLists don't miss any files #5065

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Ensure CMakeLists don't miss any files #5065

merged 4 commits into from
Oct 27, 2023

Conversation

antkmsft
Copy link
Member

No description provided.

@github-actions github-actions bot added Attestation Azure.Core Azure.Identity EngSys This issue is impacting the engineering system. KeyVault Storage Storage Service (Queues, Blobs, Files) labels Oct 26, 2023
Jinming-Hu
Jinming-Hu approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@Jinming-Hu Jinming-Hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications to storage LGTM

@antkmsft antkmsft mentioned this pull request Oct 26, 2023
Open
@LarryOsterman
Copy link
Member

In general, LGTM. But the source listings should be alphabetical, not hierarchically ordered. That allows people to select a region in VS and use the "sort items" command to sort the list.

Absent that, some enforcement mechanism would be needed.

@antkmsft
Copy link
Member Author

/check-enforcer override

@antkmsft antkmsft merged commit 50c1851 into Azure:main Oct 27, 2023
@antkmsft antkmsft deleted the cmakefiles branch October 27, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarryOsterman LarryOsterman LarryOsterman approved these changes

@Jinming-Hu Jinming-Hu Jinming-Hu approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek danieljurek is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@vinjiang vinjiang Awaiting requested review from vinjiang vinjiang is a code owner

@EmmaZhu EmmaZhu Awaiting requested review from EmmaZhu EmmaZhu is a code owner

@vhvb1989 vhvb1989 Awaiting requested review from vhvb1989

@gearama gearama Awaiting requested review from gearama gearama is a code owner

@microzchang microzchang Awaiting requested review from microzchang microzchang is a code owner

@gkostal gkostal Awaiting requested review from gkostal gkostal is a code owner

@anilba06 anilba06 Awaiting requested review from anilba06 anilba06 is a code owner

@ahmadmsft ahmadmsft Awaiting requested review from ahmadmsft ahmadmsft is a code owner

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@schaabs schaabs Awaiting requested review from schaabs

@christothes christothes Awaiting requested review from christothes christothes is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Attestation Azure.Core Azure.Identity EngSys This issue is impacting the engineering system. KeyVault Storage Storage Service (Queues, Blobs, Files)
Projects
Azure Identity SDK Improvements
Archived in project
Azure SDK for Key Vault
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antkmsft @LarryOsterman @ahsonkhan @Jinming-Hu