Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Express Route] Added Support for IPv6 Circuit Connection Configuration. #8145

Closed
wants to merge 5 commits into from
Closed

[Express Route] Added Support for IPv6 Circuit Connection Configuration. #8145

wants to merge 5 commits into from

Conversation

amwate
Copy link
Contributor

@amwate amwate commented Jan 14, 2020 •
edited
Loading

Latest improvements:

Below changes to ExpressRouteCircuitConfig are to provide the support for IPv6 properties.
The support was added to NRP in the September release. Although the feature was not published or GA'd.

The below configurations would add a node IPv6CircuitConnectionProperties to the existing expressRouteCircuitConnection object.

The above block would be used by all the northbound clients like azure-powershell/ azcli/terraform/portal.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@amwate amwate changed the title Added Support for IPv6 Circuit Connection Configuration. [Express Route] Added Support for IPv6 Circuit Connection Configuration. Jan 14, 2020
@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

anton-evseev
anton-evseev suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@anton-evseev anton-evseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address ModelValidation errors
https://dev.azure.com/azure-sdk/public/_build/results?buildId=233338&view=logs&jobId=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742

@anton-evseev anton-evseev added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 14, 2020
@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@MikhailTryakhov
Copy link
Contributor

Hey @amwate, we are close to release our monthly branch. In case you won't solve all the failed jobs/get ARM approval - your PR would be closed around midnight today.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

v-shhatt
v-shhatt reviewed Jan 16, 2020
View reviewed changes
Copy link
Contributor

@v-shhatt v-shhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed.. please fix errors

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@anton-evseev
Copy link
Contributor

network-december-release has been already merged to meep tight deadlines. If your PR is urgent, please retarget to master

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@amwate
Copy link
Contributor Author

amwate commented Jan 16, 2020

network-december-release has been already merged to meep tight deadlines. If your PR is urgent, please retarget to master

It is not urgent. We can retarget it to network-january-release when it is pulled.

@amwate
Copy link
Contributor Author

amwate commented Jan 16, 2020

Hey @amwate, we are close to release our monthly branch. In case you won't solve all the failed jobs/get ARM approval - your PR would be closed around midnight today.

Sure no problem. We can targe this in the next release.

@amwate amwate mentioned this pull request Jan 16, 2020
Closed
8 tasks
@MikhailTryakhov
Copy link
Contributor

Closing per latest comment

@amwate amwate mentioned this pull request Jan 21, 2020
Merged
5 tasks
@amwate amwate mentioned this pull request Jan 29, 2020
Closed
8 tasks
@amwate amwate mentioned this pull request Apr 6, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-shhatt v-shhatt v-shhatt left review comments

@anton-evseev anton-evseev anton-evseev requested changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@zikalino zikalino

Labels
WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amwate @MikhailTryakhov @anton-evseev @v-shhatt @zikalino