[draft] LintDiff Migration tests #32697
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
AzureRestAPISpecReview
added
data-plane
resource-manager
TypeSpec
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
| eng/ | ||
| .github/ | ||
|
|
||
| - name: Checkout 'after' state |
There was a problem hiding this comment.
We might be able to optimize the checkouts to only the folders with files changed in the PR diff.
|
|
||
| # TODO: This can probably be updated to run directly from JS | ||
| # TODO: default workspace is the after/ folder | ||
| - name: Get changed files |
There was a problem hiding this comment.
I will be creating JS-based helpers for this: #32637
There was a problem hiding this comment.
I'm not sure if we will need this tool long-term. To me this is more "glue code" that is used by CI, rather than a tool for dev inner-loop. But it's fine for now since this is likely the simplest way to lift-and-shift the existing check.
eng/tools/lint-diff/src/lint-diff.ts
Outdated
| type: "string", | ||
| short: "o", | ||
| }, | ||
| "lint-version": { |
There was a problem hiding this comment.
This parameter should be removed, and instead all necessary dependencies should be listed in a package.json. If the dependencies are to be called directly during dev inner-loop, they should be listed in the root package.json. Else, use the package,json of the tool that calls the dependencies.
There was a problem hiding this comment.
Also, autorest is special because, by default, it uses custom code to manage it's own dependendencies. However, it can be convinced to use only pre-installed deps. We will want to use this here, and I'll extract it into a common JS helper.
Here's me making this fix to tsp-client:
eng/tools/lint-diff/src/lint-diff.ts
Outdated
| } | ||
| } | ||
|
|
||
| async function executeCommand( |
There was a problem hiding this comment.
I will extract this into a shared helper.
eng/tools/lint-diff/src/lint-diff.ts
Outdated
| * TODO: TESTS | ||
| * @param changedFiles List of changed files. | ||
| */ | ||
| async function getAffectedReadmeFiles(changedFiles: string[], repoRoot: string): Promise<string[]> { |
There was a problem hiding this comment.
Might be worth making the rest of the file shared code, if we think other tools may want similar file lists.
There was a problem hiding this comment.
This should probably also be shared code
| * @param path Path to check for existence | ||
| * @returns true if the path exists, false otherwise | ||
| */ | ||
| export async function pathExists(path: string): Promise<boolean> { |
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
Co-authored-by: Mike Harder <[email protected]>
danieljurek
force-pushed
the
djurek/lintdiff-migration
branch
from
ff7dc19 to
828152b
Compare
Test a few scenarios
Some scenarios still need to be found among existing PRs.