Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Modify C# customizations and config for Key Vault Administration #32571

Merged
merged 13 commits into from
Feb 12, 2025
Merged

[Key Vault] Modify C# customizations and config for Key Vault Administration #32571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
62462ef
comment Error rename
JonathanCrd Jan 21, 2025
38c878e
Comment all C# customizations
JonathanCrd Jan 22, 2025
0f86b26
KeyVaultSettingValue
JonathanCrd Jan 22, 2025
df7661c
Uncomment access decorators
JonathanCrd Jan 22, 2025
b990663
Make KeyVault internal
JonathanCrd Jan 22, 2025
8fb44e8
Omit unreachable types
JonathanCrd Jan 23, 2025
63049d5
Move omit-unreachable-types to autorest options
JonathanCrd Jan 23, 2025
fa0d77e
use-model-reader-writer: true
JonathanCrd Feb 5, 2025
0396fc3
use model reader writer false
JonathanCrd Feb 5, 2025
deb8e3f
Rename Setting,Type to SettingType
JonathanCrd Feb 5, 2025
51ece07
Cleanup csharp customizations
JonathanCrd Feb 5, 2025
22bf0b2
format client.tsp
JonathanCrd Feb 11, 2025
e3ceb34
Remove omit-unreachable-types
JonathanCrd Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 2 additions & 116 deletions specification/keyvault/Security.KeyVault.Administration/client.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,120 +16,6 @@ namespace ClientCustomizations;
@@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "java");

//C# customizations
@@clientName(KeyVault.Setting, "KeyVaultSetting", "csharp");
@@clientName(KeyVault.Setting.value, "Content", "csharp");
@@clientName(KeyVault.Setting.type, "SettingType", "csharp");
@@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "csharp");
@@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp");
@@clientName(KeyVault.RoleScope, "KeyVaultRoleScope", "csharp");
@@clientName(KeyVault.RoleType, "KeyVaultRoleType", "csharp");
@@clientName(KeyVault.RoleAssignment, "KeyVaultRoleAssignment", "csharp");
@@clientName(KeyVault.FullBackupOperation,
"FullBackupDetailsInternal",
"csharp"
);
@@clientName(KeyVault.SettingsListResult, "GetSettingsResult", "csharp");
@@clientName(KeyVault.RoleAssignmentPropertiesWithScope,
"KeyVaultRoleAssignmentProperties",
"csharp"
);
@@clientName(KeyVault.RoleDefinitionType,
"KeyVaultRoleDefinitionType",
"csharp"
);
@@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp");
@@clientName(Error, "KeyVaultServiceError", "csharp");
@@clientName(KeyVault.DataAction, "KeyVaultDataAction", "csharp");
@@clientName(KeyVault.RestoreOperation, "RestoreDetailsInternal", "csharp");

@@access(KeyVault.RoleAssignmentCreateParameters, Access.internal, "csharp");
@@access(KeyVault.RoleDefinitionCreateParameters, Access.internal, "csharp");
@@access(KeyVault.SASTokenParameter, Access.internal, "csharp");
@@access(KeyVault.SelectiveKeyRestoreOperationParameters,
Access.internal,
"csharp"
);
@@access(KeyVault.RoleDefinitionProperties, Access.internal, "csharp");

@@clientName(KeyVault.FullBackupOperation.azureStorageBlobContainerUri,
"folderUri",
"javascript"
);

@client(
{
name: "BackupRestoreRestClient",
service: KeyVault,
},
"csharp"
)
interface BackupRestoreRestClient {
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
fullBackup is KeyVault.fullBackup;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
#suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped"
fullBackupStatus is KeyVault.fullBackupStatus;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
preFullBackup is KeyVault.preFullBackup;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
#suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped"
restoreStatus is KeyVault.restoreStatus;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
preFullRestoreOperation is KeyVault.preFullRestoreOperation;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
fullRestoreOperation is KeyVault.fullRestoreOperation;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
selectiveKeyRestoreOperation is KeyVault.selectiveKeyRestoreOperation;
}

@client(
{
name: "RoleAssignmentsRestClient",
service: KeyVault,
},
"csharp"
)
interface RoleAssignmentsRestClient {
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
delete is KeyVault.RoleAssignments.delete;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
create is KeyVault.RoleAssignments.create;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
get is KeyVault.RoleAssignments.get;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
listForScope is KeyVault.RoleAssignments.listForScope;
}

@client(
{
name: "RoleDefinitionsRestClient",
service: KeyVault,
},
"csharp"
)
interface RoleDefinitionsRestClient {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianingwang123 this should be the root cause

#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
delete is KeyVault.RoleDefinitions.delete;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
createOrUpdate is KeyVault.RoleDefinitions.createOrUpdate;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
get is KeyVault.RoleDefinitions.get;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
list is KeyVault.RoleDefinitions.list;
}

@client(
{
name: "SettingsRestClient",
service: KeyVault,
},
"csharp"
)
interface SettingsRestClient {
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
updateSetting is KeyVault.updateSetting;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
getSetting is KeyVault.getSetting;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
getSettings is KeyVault.getSettings;
}
@@clientName(KeyVault.Setting.value, "Content", "csharp");
@@access(KeyVault, Access.internal, "csharp");
1 change: 1 addition & 0 deletions specification/keyvault/Security.KeyVault.Administration/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ options:
namespace: "Azure.Security.KeyVault.Administration"
"output-path": "./src/Generated"
flavor: azure
use-model-reader-writer: false
"@azure-tools/typespec-ts":
package-dir: "keyvault-admin"
generateMetadata: true
Expand Down