Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGC v.2025-03-01-preview #32490

Merged
merged 11 commits into from
Mar 7, 2025
Merged

AGC v.2025-03-01-preview #32490

merged 11 commits into from
Mar 7, 2025

Conversation

cdxu-147
Copy link
Member

@cdxu-147 cdxu-147 commented Feb 6, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Feb 6, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Feb 6, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/servicenetworking/armservicenetworking https://apiview.dev/Assemblies/Review/dac0f14920064789802d4f9817062b17?revisionId=2f60cbe23e2f412f97d4ac085a445eba
Java azure-resourcemanager-servicenetworking https://apiview.dev/Assemblies/Review/d3d81ca11c2f4e64a72f6830e8dc0ca2?revisionId=1d5704dc889c40a4931eba79d59807f2

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 6, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ServiceNetworking
Microsoft.ServiceNetworking

@cdxu-147 cdxu-147 force-pushed the chengdexu/AGC-v2025-03-01-preview branch from a7a9220 to fdde02f Compare February 7, 2025 00:57
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Feb 7, 2025
@cdxu-147 cdxu-147 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 7, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 11, 2025
@Azure Azure deleted a comment from azure-pipelines bot Mar 5, 2025
@Azure Azure deleted a comment from azure-pipelines bot Mar 5, 2025
@cdxu-147 cdxu-147 force-pushed the chengdexu/AGC-v2025-03-01-preview branch from 42cd661 to b589d1f Compare March 5, 2025 00:39
@Azure Azure deleted a comment from azure-pipelines bot Mar 5, 2025
@cdxu-147 cdxu-147 force-pushed the chengdexu/AGC-v2025-03-01-preview branch from b589d1f to 33e3d8d Compare March 5, 2025 00:53
@cdxu-147 cdxu-147 force-pushed the chengdexu/AGC-v2025-03-01-preview branch 2 times, most recently from 919d622 to de1c48a Compare March 6, 2025 01:33
@cdxu-147 cdxu-147 force-pushed the chengdexu/AGC-v2025-03-01-preview branch from de1c48a to 283c669 Compare March 6, 2025 01:50
@tadelesh
Copy link
Member

tadelesh commented Mar 6, 2025

/azp run

@cdxu-147
Copy link
Member Author

cdxu-147 commented Mar 6, 2025

Can someone please give us approval and help merge this PR?

@cdxu-147 cdxu-147 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 6, 2025
Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda
Copy link
Member

rkmanda commented Mar 6, 2025

#32490 (comment)

@rkmanda rkmanda removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 6, 2025
@cdxu-147 cdxu-147 merged commit bfb94c8 into main Mar 7, 2025
28 of 31 checks passed
@cdxu-147 cdxu-147 deleted the chengdexu/AGC-v2025-03-01-preview branch March 7, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMAutoSignOffPreview ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants