Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New public preview API for confidential ledger code transparency 2025-01-31-preview #31896

Merged
merged 49 commits into from
Mar 6, 2025

Conversation

ivarprudnikov
Copy link
Member

@ivarprudnikov ivarprudnikov commented Dec 16, 2024

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

As this is a preview API we will deprecate and not support the prior version and all future service apis will follow this newer spec.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

fix #32559

Copy link

openapi-pipeline-app bot commented Dec 16, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Dec 16, 2024

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 16, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.CodeTransparency

@ivarprudnikov
Copy link
Member Author

Private Preview version merged was merged in #27916

@ivarprudnikov ivarprudnikov force-pushed the confidentialledger/cts/2025-01-31-preview branch from 76a25f7 to f741353 Compare December 17, 2024 15:55
@ivarprudnikov ivarprudnikov added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Dec 17, 2024
@ivarprudnikov ivarprudnikov marked this pull request as ready for review December 17, 2024 15:59
@ivarprudnikov ivarprudnikov requested a review from a team as a code owner December 17, 2024 15:59
@ivarprudnikov ivarprudnikov requested review from JeffreyRichter and mario-guerra and removed request for a team December 17, 2024 15:59
@ivarprudnikov ivarprudnikov changed the title [DRAFT][WIP] New public preview API for confidential ledger code transparency 2025-01-31-preview New public preview API for confidential ledger code transparency 2025-01-31-preview Dec 17, 2024
@mikeharder
Copy link
Member

@danieljurek: Please investigate the failure of Swagger ApiDocPreview.

@maririos
Copy link
Member

maririos commented Mar 5, 2025

Based on conversations internally in the team I approved the suppressions added

@ivarprudnikov ivarprudnikov enabled auto-merge (squash) March 6, 2025 12:29
@ivarprudnikov ivarprudnikov merged commit 6103692 into main Mar 6, 2025
25 of 28 checks passed
@ivarprudnikov ivarprudnikov deleted the confidentialledger/cts/2025-01-31-preview branch March 6, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. Approved-Suppression data-plane new-api-version PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. SuppressionReviewRequired TypeSpec Authored with TypeSpec Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure Confidential Computing Ledger ] API Review
9 participants