Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typespec for ApplicationInsights LiveMetrics #28320

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Merge branch 'main' into TimothyMothra-patch-1

5e0da64
Select commit
Loading
Failed to load commit list.
Draft

Update typespec for ApplicationInsights LiveMetrics #28320

Merge branch 'main' into TimothyMothra-patch-1
5e0da64
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / [ignore this check status; not blocking PR merge] Swagger LintDiff succeeded May 2, 2024 in 4m 27s

[ignore this check status; not blocking PR merge] Swagger LintDiff succeeded

Caution

❗THIS CHECK IS NOT BLOCKING PR MERGE, EVEN IF FAILING / RED / QUEUED. PLEASE IGNORE IT❗

ppe/LintDiff
View Azure DevOps build log for more details.

Details

compared tags (via openapi-validator vbeta) new version base version
2024-04-01-preview 2024-04-01-preview(5e0da64) 2024-04-01-preview(main)

The following errors/warnings exist before current PR submission:

Rule Message
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L700
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L696
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L170
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L168
⚠️ RequestBodyOptional The body parameter is not marked as required.
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L147
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L132
⚠️ ErrorResponse Error response schema should contain an object property named error.
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L118
⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L116
⚠️ RequestBodyOptional The body parameter is not marked as required.
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L87
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L57
⚠️ SecurityDefinitionDescription Security definition should have a description.
Location: LiveMetrics/preview/2024-04-01-preview/livemetrics.json#L44