Skip to content

Commit

Permalink
[Key Vault] Modify C# customizations and config for Key Vault Adminis…
Browse files Browse the repository at this point in the history
…tration (#32571)

* comment Error rename

* Comment all C# customizations

* KeyVaultSettingValue

* Uncomment access decorators

* Make KeyVault internal

* Omit unreachable types

* Move omit-unreachable-types to autorest options

* use-model-reader-writer: true

* use model reader writer false

* Rename Setting,Type to SettingType

* Cleanup csharp customizations

* format client.tsp

* Remove omit-unreachable-types
  • Loading branch information
JonathanCrd authored Feb 12, 2025
1 parent 1aafda2 commit 6b9d2ce
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 116 deletions.
118 changes: 2 additions & 116 deletions specification/keyvault/Security.KeyVault.Administration/client.tsp
Original file line number Diff line number Diff line change
Expand Up @@ -16,120 +16,6 @@ namespace ClientCustomizations;
@@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "java");

//C# customizations
@@clientName(KeyVault.Setting, "KeyVaultSetting", "csharp");
@@clientName(KeyVault.Setting.value, "Content", "csharp");
@@clientName(KeyVault.Setting.type, "SettingType", "csharp");
@@clientName(KeyVault.SettingTypeEnum, "KeyVaultSettingType", "csharp");
@@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp");
@@clientName(KeyVault.RoleScope, "KeyVaultRoleScope", "csharp");
@@clientName(KeyVault.RoleType, "KeyVaultRoleType", "csharp");
@@clientName(KeyVault.RoleAssignment, "KeyVaultRoleAssignment", "csharp");
@@clientName(KeyVault.FullBackupOperation,
"FullBackupDetailsInternal",
"csharp"
);
@@clientName(KeyVault.SettingsListResult, "GetSettingsResult", "csharp");
@@clientName(KeyVault.RoleAssignmentPropertiesWithScope,
"KeyVaultRoleAssignmentProperties",
"csharp"
);
@@clientName(KeyVault.RoleDefinitionType,
"KeyVaultRoleDefinitionType",
"csharp"
);
@@clientName(KeyVault.Permission, "KeyVaultPermission", "csharp");
@@clientName(Error, "KeyVaultServiceError", "csharp");
@@clientName(KeyVault.DataAction, "KeyVaultDataAction", "csharp");
@@clientName(KeyVault.RestoreOperation, "RestoreDetailsInternal", "csharp");

@@access(KeyVault.RoleAssignmentCreateParameters, Access.internal, "csharp");
@@access(KeyVault.RoleDefinitionCreateParameters, Access.internal, "csharp");
@@access(KeyVault.SASTokenParameter, Access.internal, "csharp");
@@access(KeyVault.SelectiveKeyRestoreOperationParameters,
Access.internal,
"csharp"
);
@@access(KeyVault.RoleDefinitionProperties, Access.internal, "csharp");

@@clientName(KeyVault.FullBackupOperation.azureStorageBlobContainerUri,
"folderUri",
"javascript"
);

@client(
{
name: "BackupRestoreRestClient",
service: KeyVault,
},
"csharp"
)
interface BackupRestoreRestClient {
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
fullBackup is KeyVault.fullBackup;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
#suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped"
fullBackupStatus is KeyVault.fullBackupStatus;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
preFullBackup is KeyVault.preFullBackup;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
#suppress "@azure-tools/typespec-azure-core/use-standard-names" "Operation name has already shipped"
restoreStatus is KeyVault.restoreStatus;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
preFullRestoreOperation is KeyVault.preFullRestoreOperation;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
fullRestoreOperation is KeyVault.fullRestoreOperation;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
selectiveKeyRestoreOperation is KeyVault.selectiveKeyRestoreOperation;
}

@client(
{
name: "RoleAssignmentsRestClient",
service: KeyVault,
},
"csharp"
)
interface RoleAssignmentsRestClient {
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
delete is KeyVault.RoleAssignments.delete;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
create is KeyVault.RoleAssignments.create;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
get is KeyVault.RoleAssignments.get;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
listForScope is KeyVault.RoleAssignments.listForScope;
}

@client(
{
name: "RoleDefinitionsRestClient",
service: KeyVault,
},
"csharp"
)
interface RoleDefinitionsRestClient {
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
delete is KeyVault.RoleDefinitions.delete;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
createOrUpdate is KeyVault.RoleDefinitions.createOrUpdate;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
get is KeyVault.RoleDefinitions.get;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
list is KeyVault.RoleDefinitions.list;
}

@client(
{
name: "SettingsRestClient",
service: KeyVault,
},
"csharp"
)
interface SettingsRestClient {
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
updateSetting is KeyVault.updateSetting;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
getSetting is KeyVault.getSetting;
#suppress "@azure-tools/typespec-azure-core/use-standard-operations" "Doesn't fit standard ops"
getSettings is KeyVault.getSettings;
}
@@clientName(KeyVault.Setting.value, "Content", "csharp");
@@access(KeyVault, Access.internal, "csharp");
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ options:
namespace: "Azure.Security.KeyVault.Administration"
"output-path": "./src/Generated"
flavor: azure
use-model-reader-writer: false
"@azure-tools/typespec-ts":
package-dir: "keyvault-admin"
generateMetadata: true
Expand Down

0 comments on commit 6b9d2ce

Please sign in to comment.