Support Advanced Threat Protection policy management #8523

shblum · 2019-02-12T21:47:11Z

Description

Adding Get/Set Advanced Threat Protection cmdlets + Tests + Help files.

Design Review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/237

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review (Microsoft internal partners only)
- the cmdlet markdown files were generated using the platyPS module

adxsdkps · 2019-02-12T21:51:51Z

Can one of the admins verify this patch?

maddieclayton · 2019-02-12T22:34:27Z

@azuresdkci Add to whitelist

maddieclayton · 2019-02-12T22:34:59Z

@shblum Please link existing design review or fill out a new design review here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues

cormacpayne · 2019-02-12T22:53:02Z

Cmdlet review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/237

shblum · 2019-02-13T06:25:31Z

Design review link is in the description.

maddieclayton · 2019-02-13T18:08:13Z

@shblum Please fix help validation errors: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell/10723/artifact/artifacts/ValidateHelpIssues.csv/*view*/

Add DefaultParameterSetName

shblum · 2019-02-14T14:10:48Z

@shblum Please fix help validation errors: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell/10723/artifact/artifacts/ValidateHelpIssues.csv/*view*/

Fixed

maddieclayton · 2019-02-14T21:55:36Z

src/Security/Security.Test/ScenarioTests/SecurityAdvancedThreatProtectionTests.ps1

+function Get-AdvancedThreatProtectionTestEnvironmentParameters ($testSuffix)
+{
+	return @{ subscriptionId =  (Get-AzContext).Subscription.Id;
+			rgName = "storage-atp-cmdlet-test-rg" +$testSuffix;


Please use "getAssetName" to add an element of randomness to your resource name generation.

maddieclayton · 2019-02-14T21:57:30Z

src/Security/Security.Test/ScenarioTests/SecurityAdvancedThreatProtectionTests.ps1

+			rgName = "storage-atp-cmdlet-test-rg" +$testSuffix;
+			accountName = "storage" +$testSuffix;
+			storageSku = "Standard_GRS";
+			location = "West Central US"


Please use GetLocation -ProviderNamespace <namespace> -ResourceType <resourcetype> -PreferredLocation "West Central US" to future proof the recording process.

maddieclayton · 2019-02-14T22:01:57Z

src/Security/Security.Test/ScenarioTests/TestController.cs

@@ -63,21 +63,33 @@ public void RunPowerShellTest(ServiceManagement.Common.Models.XunitTracingInterc
                    _helper.RMProfileModule,
                    _helper.GetRMModulePath(@"AzureRM.Security.psd1"),
                    "ScenarioTests\\Common.ps1",
-                    "ScenarioTests\\" + callingClassName + ".ps1");
+                    "ScenarioTests\\" + callingClassName + ".ps1",
+                    _helper.GetRMModulePath(@"AzureRM.Resources"),


Instead of using the Resources and Storage modules, please use our internal version of these cmdlets. This is just changing this import to the two ps1 files:

azure-powershell/src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/TestsBase.cs

Line 145 in d99d9f8

"AzureRM.Storage.ps1",

, and updating the client to the common version:

azure-powershell/src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/TestsBase.cs

Line 32 in d99d9f8

using Microsoft.Azure.Management.Storage.Version2017_10_01;

,

azure-powershell/src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/TestsBase.cs

Line 29 in d99d9f8

using Microsoft.Azure.Management.Internal.Resources;

maddieclayton · 2019-02-14T22:02:35Z

src/Security/Security.Test/Security.Test.csproj

@@ -11,7 +11,8 @@
  </PropertyGroup>

  <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.SecurityCenter" Version="0.10.0-preview" />
+    <PackageReference Include="Microsoft.Azure.Management.SecurityCenter" Version="0.11.0-preview" />
+	 <PackageReference Include="Microsoft.Azure.Management.Storage" Version="9.1.0-preview" />


You can remove this once you update to the common client.

maddieclayton · 2019-02-14T22:08:55Z

src/Security/Security/help/Az.Security.md

@@ -41,6 +41,9 @@ Gets the pricing tier data for Azure Security Center for a scope.
 ### [Get-AzSecurityTask](Get-AzSecurityTask.md)
 Gets the security tasks that Azure Security Center recommends you to do in order to strengthen your security posture.

+### [Get-AzSecurityThreatProtection](Get-AzSecurityThreatProtection.md)
+{{Fill in the Synopsis}}


Please copy over the synopsis here for the two new cmdlets.

maddieclayton · 2019-02-14T22:09:16Z

src/Security/Security/help/Get-AzSecurityThreatProtection.md

+```
+
+## DESCRIPTION
+The "Get-AzSecurityThreatProtection" cmdlet gets the threat protetion policy of a storage account.


*protection

maddieclayton · 2019-02-14T22:09:31Z

src/Security/Security/help/Get-AzSecurityThreatProtection.md

+
+### Example 1
+```powershell
+PS C:\> Get-AzSecurityThreatProtection -ResourceId "/subscriptions/cma24pc8-89b5-4aa7-9ff6-486e886c304a/resourceGroups/myResourceGroup/providers/Microsoft.Storage/storageAccounts/myStorageAccount/"


Please add example output for all examples

Please also remove the subscription and replace with xxxxxxx-xxxx-xxxx-xxxxxxxxxxxxx

maddieclayton · 2019-02-14T22:10:13Z

src/Security/Security/help/Get-AzSecurityThreatProtection.md

+PS C:\> Get-AzSecurityThreatProtection -ResourceId "/subscriptions/cma24pc8-89b5-4aa7-9ff6-486e886c304a/resourceGroups/myResourceGroup/providers/Microsoft.Storage/storageAccounts/myStorageAccount/"
+```
+
+This command gets the threat protection policy for resource id "/subscriptions/cma24pc8-89b5-4aa7-9ff6-486e886c304a/resourceGroups/myResourceGroup/providers/Microsoft.Storage/storageAccounts/myStorageAccount/".


xxxxxxx-xxxx-xxxx-xxxxxxxxxxxxx for subscription

maddieclayton · 2019-02-14T22:11:52Z

Just to reiterate Cormac's comments in the design review, this design is fine for a preview release, but will need to be revisited before the stable release as it doesn't match our standards for stable.

shblum added 2 commits February 6, 2019 19:03

Help files for Get/Set-AzSecurityThreatProtection

2aaa7da

Get-Set ATP storage + Test+Help

2a8763d

azuresdkci added the needs-review label Feb 12, 2019

maddieclayton added Cmdlet Review Required ⚠️ and removed needs-review labels Feb 12, 2019

maddieclayton assigned shblum Feb 12, 2019

cormacpayne added Cmdlet Review Complete and removed Cmdlet Review Required ⚠️ labels Feb 12, 2019

cormacpayne assigned cormacpayne and unassigned shblum Feb 12, 2019

cormacpayne added the needs-review label Feb 12, 2019

maddieclayton added needs-revision and removed needs-review labels Feb 13, 2019

maddieclayton assigned shblum and unassigned cormacpayne Feb 13, 2019

shblum and others added 5 commits February 14, 2019 11:18

Update Get-AzSecurityThreatProtection.md

6ed9fd9

Update Set-AzSecurityThreatProtection.md

2d77c74

Update Get-AzSecurityThreatProtection.md

2d7777c

Update SetThreatProtectionPolicy .cs

d272955

Add DefaultParameterSetName

Merge branch 'master' of https://github.com/shblum/azure-powershell

8f4621e

maddieclayton added needs-review and removed needs-revision labels Feb 14, 2019

maddieclayton unassigned shblum Feb 14, 2019

maddieclayton self-assigned this Feb 14, 2019

maddieclayton suggested changes Feb 14, 2019

View reviewed changes

maddieclayton added needs-revision and removed needs-review labels Feb 14, 2019

maddieclayton assigned shblum and unassigned maddieclayton Feb 14, 2019

shblum and others added 3 commits February 15, 2019 03:18

iter2

eef4981

Update Get-AzSecurityThreatProtection.md

5442cea

Update Set-AzSecurityThreatProtection.md

680df5e

maddieclayton added needs-review and removed needs-revision labels Feb 15, 2019

maddieclayton assigned maddieclayton and unassigned shblum Feb 15, 2019

Maddie Clayton added 2 commits February 15, 2019 10:36

Update Set-AzSecurityThreatProtection.md

3979f20

Update Get-AzSecurityThreatProtection.md

57a2dbd

maddieclayton approved these changes Feb 15, 2019

View reviewed changes

maddieclayton added Waiting for CI and removed Cmdlet Review Complete needs-review labels Feb 15, 2019

maddieclayton removed their assignment Feb 15, 2019

maddieclayton merged commit c18b690 into Azure:master Feb 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Advanced Threat Protection policy management #8523

Support Advanced Threat Protection policy management #8523

shblum commented Feb 12, 2019 •

edited

Loading

adxsdkps commented Feb 12, 2019

maddieclayton commented Feb 12, 2019

maddieclayton commented Feb 12, 2019

cormacpayne commented Feb 12, 2019

shblum commented Feb 13, 2019

maddieclayton commented Feb 13, 2019

shblum commented Feb 14, 2019

maddieclayton Feb 14, 2019

maddieclayton Feb 14, 2019

maddieclayton Feb 14, 2019

maddieclayton Feb 14, 2019

maddieclayton Feb 14, 2019

maddieclayton Feb 14, 2019

maddieclayton Feb 14, 2019

maddieclayton Feb 14, 2019

maddieclayton Feb 14, 2019

maddieclayton commented Feb 14, 2019

Support Advanced Threat Protection policy management #8523

Support Advanced Threat Protection policy management #8523

Conversation

shblum commented Feb 12, 2019 • edited Loading

Description

Checklist

adxsdkps commented Feb 12, 2019

maddieclayton commented Feb 12, 2019

maddieclayton commented Feb 12, 2019

cormacpayne commented Feb 12, 2019

shblum commented Feb 13, 2019

maddieclayton commented Feb 13, 2019

shblum commented Feb 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maddieclayton commented Feb 14, 2019

shblum commented Feb 12, 2019 •

edited

Loading