Adding SBM support #24116

ananyabhatia-msft · 2024-02-06T12:15:51Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell
- General release
- Public preview
- Private preview
- Engineering build
- N/A
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2024-02-06T12:15:54Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

⚠️Az.Migrate

️✔️Build

️✔️PowerShell Core - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

⚠️Signature Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzMigrateHCIJob Get-AzMigrateHCIJob Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateHCIJob Get-AzMigrateHCIJob changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateHCIReplicationFabric Get-AzMigrateHCIReplicationFabric Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateHCIReplicationFabric Get-AzMigrateHCIReplicationFabric changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateHCIServerReplication Get-AzMigrateHCIServerReplication Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateHCIServerReplication Get-AzMigrateHCIServerReplication changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateJob Get-AzMigrateJob Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateJob Get-AzMigrateJob changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateProject Get-AzMigrateProject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateProject Get-AzMigrateProject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateReplicationFabric Get-AzMigrateReplicationFabric Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateReplicationFabric Get-AzMigrateReplicationFabric changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateReplicationPolicy Get-AzMigrateReplicationPolicy Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateReplicationPolicy Get-AzMigrateReplicationPolicy changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateReplicationProtectionContainer Get-AzMigrateReplicationProtectionContainer Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateReplicationProtectionContainer Get-AzMigrateReplicationProtectionContainer changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateReplicationProtectionContainerMapping Get-AzMigrateReplicationProtectionContainerMapping Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateReplicationProtectionContainerMapping Get-AzMigrateReplicationProtectionContainerMapping changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateReplicationRecoveryServicesProvider Get-AzMigrateReplicationRecoveryServicesProvider Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateReplicationRecoveryServicesProvider Get-AzMigrateReplicationRecoveryServicesProvider changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateRunAsAccount Get-AzMigrateRunAsAccount Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateRunAsAccount Get-AzMigrateRunAsAccount changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateServerReplication Get-AzMigrateServerReplication Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateServerReplication Get-AzMigrateServerReplication changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateSite Get-AzMigrateSite Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateSite Get-AzMigrateSite changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzMigrateSolution Get-AzMigrateSolution Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzMigrateSolution Get-AzMigrateSolution changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ New-AzMigrateDiskMapping New-AzMigrateDiskMapping Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ New-AzMigrateDiskMapping New-AzMigrateDiskMapping changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ New-AzMigrateHCIDiskMappingObject New-AzMigrateHCIDiskMappingObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ New-AzMigrateHCINicMappingObject New-AzMigrateHCINicMappingObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ New-AzMigrateNicMapping New-AzMigrateNicMapping Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ New-AzMigrateNicMapping New-AzMigrateNicMapping changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ New-AzMigrateServerReplication New-AzMigrateServerReplication Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ New-AzMigrateServerReplication New-AzMigrateServerReplication changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Remove-AzMigrateServerReplication Remove-AzMigrateServerReplication Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Remove-AzMigrateServerReplication Remove-AzMigrateServerReplication changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Restart-AzMigrateServerReplication Restart-AzMigrateServerReplication Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Restart-AzMigrateServerReplication Restart-AzMigrateServerReplication changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Set-AzMigrateDiskMapping Set-AzMigrateDiskMapping Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Set-AzMigrateDiskMapping Set-AzMigrateDiskMapping changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Set-AzMigrateServerReplication Set-AzMigrateServerReplication Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Set-AzMigrateServerReplication Set-AzMigrateServerReplication changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Start-AzMigrateServerMigration Start-AzMigrateServerMigration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Start-AzMigrateServerMigration Start-AzMigrateServerMigration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Start-AzMigrateTestMigration Start-AzMigrateTestMigration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Start-AzMigrateTestMigration Start-AzMigrateTestMigration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Start-AzMigrateTestMigrationCleanup Start-AzMigrateTestMigrationCleanup Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Start-AzMigrateTestMigrationCleanup Start-AzMigrateTestMigrationCleanup changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

⚠️File Change Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Migrate. Add a changelog record under Upcoming Release section with past tense.

️✔️UX Metadata Check

️✔️PowerShell Core - Windows

️✔️Test

️✔️PowerShell Core - Linux

️✔️PowerShell Core - MacOS

️✔️PowerShell Core - Windows

github-actions · 2024-02-06T12:34:51Z

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

src/Migrate/Migrate.Autorest/custom/Initialize-AzMigrateReplicationInfrastructure.ps1

msJinLei · 2024-02-26T09:57:23Z

@ananyabhatia-msft please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@ananyabhatia-msft Please sign the agreement

msJinLei

Please add the test for your changes

github-actions · 2024-02-26T10:01:33Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

ananyabhatia-msft · 2024-04-08T05:51:40Z

@ananyabhatia-msft please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

YanaXu · 2024-04-24T09:37:16Z

Hi @ananyabhatia-msft , please join your github account to Azure org.

Link your GitHub Account with Microsoft Account on this page: Open Source Management Portal / Account link
Join below organizations on this page: Open Source Management Portal / Organizations
- Azure

YanaXu

Could you please add tests for your update? It's hard to tell from the change if it's OK.

github-actions · 2024-04-24T09:39:48Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

ananyabhatia-msft · 2024-04-29T06:43:56Z

Could you please add tests for your update? It's hard to tell from the change if it's OK.

The test are already in src/Migrate/Migrate.Autorest/test/Initialize-AzMigrateReplicationInfrastructure.Tests.ps1

YanaXu · 2024-04-29T09:44:12Z

Hi @ananyabhatia-msft , please join the GitHub org as this commet.
And could you update the test to remove "LiveOnly"? "LiveOnly" tests will not be run in CI checks. That means we can't see if it's OK or not.

ananyabhatia-msft · 2024-05-01T06:22:39Z

Hi @ananyabhatia-msft , please join the GitHub org as this commet. And could you update the test to remove "LiveOnly"? "LiveOnly" tests will not be run in CI checks. That means we can't see if it's OK or not.

Hi
We were instructed by a reveiwer to add the LiveOnly flag, since recording based tests were not allowed for custom cmdlets

Here is the link to post where you can find more details about the discussion.

YanaXu · 2024-05-08T03:24:59Z

src/Migrate/Migrate.Autorest/custom/Initialize-AzMigrateReplicationInfrastructure.ps1

+    [string]$objectId,
+    [string]$saId) {
+
+    $storageBlobDataContributorRoleDefinitionId = "ba92f5b4-2d11-453d-a403-e96b0029c9fe"


It's a hardcoded id. Could you explain more about this?

This is id of the role definition (Storage Blob Data Contributor), taken from the azure documentation: link

I see the ids are defined in 'src/Migrate/Migrate.Autorest/custom/Helper/AzStackHCICommonSettings.ps1'. Please refer to this ps1 file like this.

YanaXu · 2024-05-08T03:29:21Z

Hi @ananyabhatia-msft , please join the GitHub org as this commet. And could you update the test to remove "LiveOnly"? "LiveOnly" tests will not be run in CI checks. That means we can't see if it's OK or not.

Hi We were instructed by a reveiwer to add the LiveOnly flag, since recording based tests were not allowed for custom cmdlets

Here is the link to post where you can find more details about the discussion.

Hi @ananyabhatia-msft, it's due to the limiation of test workflow. If so, could you at least provide a screenshot of your live test?

ananyabhatia-msft · 2024-12-11T07:54:00Z

Hi @ananyabhatia-msft , please join the GitHub org as this commet. And could you update the test to remove "LiveOnly"? "LiveOnly" tests will not be run in CI checks. That means we can't see if it's OK or not.

Hi We were instructed by a reveiwer to add the LiveOnly flag, since recording based tests were not allowed for custom cmdlets
Here is the link to post where you can find more details about the discussion.

Hi @ananyabhatia-msft, it's due to the limiation of test workflow. If so, could you at least provide a screenshot of your live test?

Hi @YanaXu
Attaching the screenshots for successful runs for both Public endpoint and Private endpoint scenarios.
Public:

Private:

YanaXu · 2024-12-11T07:59:06Z

/azp run

azure-pipelines · 2024-12-11T07:59:23Z

Azure Pipelines successfully started running 3 pipeline(s).

YanaXu · 2024-12-16T02:28:47Z

/azp run

azure-pipelines · 2024-12-16T02:29:03Z

Azure Pipelines successfully started running 3 pipeline(s).

confirmed with reviewer and dismiss.

Adding SBM support

96c83bd

microsoft-github-policy-service bot added the customer-reported label Feb 6, 2024

singhabh27 added the Do Not Merge 🚫 label Feb 6, 2024

singhabh27 reviewed Feb 20, 2024

View reviewed changes

src/Migrate/Migrate.Autorest/custom/Initialize-AzMigrateReplicationInfrastructure.ps1 Outdated Show resolved Hide resolved

singhabh27 requested a review from prsadhu-ms-idc February 20, 2024 12:49

Fixing error message

a59e957

singhabh27 suggested changes Feb 21, 2024

View reviewed changes

Resolving comments - iteration 1

b6547f9

ananyabhatia-msft commented Feb 22, 2024

View reviewed changes

src/Migrate/Migrate.Autorest/custom/Initialize-AzMigrateReplicationInfrastructure.ps1 Show resolved Hide resolved

Fixing bug in PE scenario

76d1cb4

msJinLei previously requested changes Feb 26, 2024

View reviewed changes

msJinLei added the needs-revision label Feb 26, 2024

ananyabhatia-msft added 3 commits February 29, 2024 14:34

Resolving comments - iteration 2

0b5ccfc

Replacing ceq with eq for string comparison

423d8a8

Marking InitializeInfra test as LiveOnly, removing skip

0fd3e9a

singhabh27 removed Do Not Merge 🚫 needs-revision labels Apr 22, 2024

YanaXu reviewed Apr 24, 2024

View reviewed changes

YanaXu added the needs-revision label Apr 24, 2024

YanaXu reviewed May 8, 2024

View reviewed changes

YanaXu added Waiting for Verification 🔍 and removed customer-reported labels May 8, 2024

Update role definition IDs and import module

57d9f15

YanaXu approved these changes Dec 16, 2024

View reviewed changes

singhabh27 removed the request for review from prsadhu-ms-idc December 16, 2024 04:35

YanaXu merged commit 0f01642 into Azure:generation Dec 17, 2024
9 checks passed

azure-powershell-bot mentioned this pull request Dec 17, 2024

Migrate Migrate from generation to main #26883

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding SBM support #24116

Adding SBM support #24116

ananyabhatia-msft commented Feb 6, 2024 •

edited by msJinLei

Loading

azure-client-tools-bot-prd bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024

msJinLei commented Feb 26, 2024

msJinLei left a comment

github-actions bot commented Feb 26, 2024

ananyabhatia-msft commented Apr 8, 2024

YanaXu commented Apr 24, 2024

YanaXu left a comment

github-actions bot commented Apr 24, 2024

ananyabhatia-msft commented Apr 29, 2024

YanaXu commented Apr 29, 2024

ananyabhatia-msft commented May 1, 2024

YanaXu May 8, 2024

ananyabhatia-msft Nov 13, 2024

YanaXu Dec 12, 2024

ananyabhatia-msft Dec 13, 2024

YanaXu commented May 8, 2024

ananyabhatia-msft commented Dec 11, 2024

YanaXu commented Dec 11, 2024

azure-pipelines bot commented Dec 11, 2024

YanaXu commented Dec 16, 2024

azure-pipelines bot commented Dec 16, 2024

Adding SBM support #24116

Adding SBM support #24116

Conversation

ananyabhatia-msft commented Feb 6, 2024 • edited by msJinLei Loading

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Feb 6, 2024 • edited Loading

github-actions bot commented Feb 6, 2024

msJinLei commented Feb 26, 2024

msJinLei left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 26, 2024

ananyabhatia-msft commented Apr 8, 2024

YanaXu commented Apr 24, 2024

YanaXu left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 24, 2024

ananyabhatia-msft commented Apr 29, 2024

YanaXu commented Apr 29, 2024

ananyabhatia-msft commented May 1, 2024

YanaXu May 8, 2024

Choose a reason for hiding this comment

ananyabhatia-msft Nov 13, 2024

Choose a reason for hiding this comment

YanaXu Dec 12, 2024

Choose a reason for hiding this comment

ananyabhatia-msft Dec 13, 2024

Choose a reason for hiding this comment

YanaXu commented May 8, 2024

ananyabhatia-msft commented Dec 11, 2024

YanaXu commented Dec 11, 2024

azure-pipelines bot commented Dec 11, 2024

YanaXu commented Dec 16, 2024

azure-pipelines bot commented Dec 16, 2024

ananyabhatia-msft commented Feb 6, 2024 •

edited by msJinLei

Loading

azure-client-tools-bot-prd bot commented Feb 6, 2024 •

edited

Loading