NSP api version update #23675
Merged
NSP api version update #23675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushal087
requested review from
isra-fel,
bilaakpan-ms,
Sandido,
haagha and
grizzlytheodore
as code owners
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzNetworkSecurityPerimeter | Get-AzNetworkSecurityPerimeter Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNetworkSecurityPerimeter | Get-AzNetworkSecurityPerimeter changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzNetworkSecurityPerimeterAccessRule | Get-AzNetworkSecurityPerimeterAccessRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNetworkSecurityPerimeterAccessRule | Get-AzNetworkSecurityPerimeterAccessRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzNetworkSecurityPerimeterAssociableResourceType | Get-AzNetworkSecurityPerimeterAssociableResourceType Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNetworkSecurityPerimeterAssociableResourceType | Get-AzNetworkSecurityPerimeterAssociableResourceType changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzNetworkSecurityPerimeterAssociation | Get-AzNetworkSecurityPerimeterAssociation Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNetworkSecurityPerimeterAssociation | Get-AzNetworkSecurityPerimeterAssociation changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzNetworkSecurityPerimeterLink | Get-AzNetworkSecurityPerimeterLink Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNetworkSecurityPerimeterLink | Get-AzNetworkSecurityPerimeterLink changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzNetworkSecurityPerimeterLinkReference | Get-AzNetworkSecurityPerimeterLinkReference Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNetworkSecurityPerimeterLinkReference | Get-AzNetworkSecurityPerimeterLinkReference changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzNetworkSecurityPerimeterProfile | Get-AzNetworkSecurityPerimeterProfile Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNetworkSecurityPerimeterProfile | Get-AzNetworkSecurityPerimeterProfile changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Get-AzNetworkSecurityPerimeter 4 3 Mismatched_Parameter_Value_Type Get-AzNetworkSecurityPerimeter -InputObject $GETObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeter.(Command). ⚠️ Get-AzNetworkSecurityPerimeterAccessRule 3 3 Mismatched_Parameter_Value_Type Get-AzNetworkSecurityPerimeterAccessRule -InputObject $GETObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspAccessRule.(Command). ⚠️ Get-AzNetworkSecurityPerimeterAssociation 3 3 Mismatched_Parameter_Value_Type Get-AzNetworkSecurityPerimeterAssociation -InputObject $GETObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspAssociation.(Command). ⚠️ Get-AzNetworkSecurityPerimeterProfile 3 3 Mismatched_Parameter_Value_Type Get-AzNetworkSecurityPerimeterProfile -InputObject $GETObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspProfile.(Command). ⚠️ Remove-AzNetworkSecurityPerimeter 2 3 Mismatched_Parameter_Value_Type Remove-AzNetworkSecurityPerimeter -InputObject $nspObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeter.(Command). ⚠️ Remove-AzNetworkSecurityPerimeterAccessRule 2 3 Mismatched_Parameter_Value_Type Remove-AzNetworkSecurityPerimeterAccessRule -InputObject $accessRuleObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspAccessRule.(Command). ⚠️ Remove-AzNetworkSecurityPerimeterAssociation 2 3 Mismatched_Parameter_Value_Type Remove-AzNetworkSecurityPerimeterAssociation -InputObject $associationObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspAssociation.(Command). ⚠️ Remove-AzNetworkSecurityPerimeterLink 2 2 Mismatched_Parameter_Value_Type Remove-AzNetworkSecurityPerimeterLink -InputObject $linkObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspLink.(Command). ⚠️ Remove-AzNetworkSecurityPerimeterLinkReference 2 2 Mismatched_Parameter_Value_Type Remove-AzNetworkSecurityPerimeterLinkReference -InputObject $linkRefObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspLinkReference.(Command). ⚠️ Remove-AzNetworkSecurityPerimeterProfile 2 3 Mismatched_Parameter_Value_Type Remove-AzNetworkSecurityPerimeterProfile -InputObject $profileObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspProfile.(Command). ⚠️ Update-AzNetworkSecurityPerimeterAccessRule 2 3 Mismatched_Parameter_Value_Type Update-AzNetworkSecurityPerimeterAccessRule -InputObject $GETObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspAccessRule.(Command). ⚠️ Update-AzNetworkSecurityPerimeterAssociation 2 3 Mismatched_Parameter_Value_Type Update-AzNetworkSecurityPerimeterAssociation -InputObject $GETObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspAssociation.(Command). ⚠️ Update-AzNetworkSecurityPerimeterLink 2 3 Mismatched_Parameter_Value_Type Update-AzNetworkSecurityPerimeterLink -InputObject $getLinkObj is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INetworkSecurityPerimeterIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.NetworkSecurityPerimeter.Models.INspLink.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Network. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
added 2 commits
December 6, 2023 19:01
|
Everything is okay and PR is ready for review. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dolauli
force-pushed
the
generation-network-preview
branch
2 times, most recently
from
79085c8 to
4e4ceb6
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dolauli
force-pushed
the
generation-network-preview
branch
from
4e4ceb6 to
d8c8362
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@kaushal087 I have enabled the CI for your preview branch. And I have made some changes in your code to migrate to autorest.powershell v4. And there are still issues in your PR. Please do following things.
|
added 2 commits
December 17, 2023 00:36
|
@dolauli , I have synced with generation-network-preview. And wrote test cases . Please help with the merge. |
|
@kaushal087 There are some example issues detected by the CI. Please fix them |
dolauli
approved these changes
Dec 20, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.