Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboard Migrate to Private Link Common Cmdlets #13403

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Onboard Migrate to Private Link Common Cmdlets #13403

merged 2 commits into from
Nov 10, 2020

Conversation

abhiroop-goyal
Copy link
Contributor

@abhiroop-goyal abhiroop-goyal commented Nov 3, 2020 •
edited
Loading

Description

Added PrivateLink support for ARM resources of the Migrate team.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

isra-fel
isra-fel requested changes Nov 4, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abhiroop-goyal , please see my inline comments about removing change logs.

Besides, have you tested private link support after you registered resource types of migrate to network?

src/Network/Network/ChangeLog.md Outdated
@@ -19,6 +19,7 @@
--->

## Upcoming Release
* Onboard Migrate to Private Link Common Cmdlets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our practice is not to update Network's changelog for private link support, so please remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the changelog

src/Migrate/Changelog.md Outdated
@@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Onboard Migrate to Private Link Common Cmdlets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrate module does not change a thing, so change log should not be updated. Please remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the changelog

@isra-fel
Copy link
Member

isra-fel commented Nov 4, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@abhiroop-goyal
Copy link
Contributor Author

our integration with NRP is complete and we have tested it for all 3 of our resourceTypes.

@abhiroop-goyal
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel added this to the S178 (2020-11-17) milestone Nov 10, 2020
@isra-fel isra-fel self-assigned this Nov 10, 2020
@isra-fel isra-fel merged commit c5ba59b into Azure:master Nov 10, 2020
@greenms greenms mentioned this pull request Nov 16, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@isra-fel isra-fel

@abhiroop-goyal abhiroop-goyal

Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
S178 (2020-11-17)
Development

Successfully merging this pull request may close these issues.
4 participants
@abhiroop-goyal @isra-fel @azuresdkci @abhiroop-goyal-ms