Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display AzurePowershell Survey url for Resolve-Error #11041

Closed
wants to merge 1 commit into from
Closed

Display AzurePowershell Survey url for Resolve-Error #11041

wants to merge 1 commit into from

Conversation

msJinLei
Copy link
Contributor

@msJinLei msJinLei commented Feb 6, 2020 •
edited
Loading

issue : #11021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@msJinLei msJinLei changed the title Display AzurePowershell Survey url for Resolve-Error & Send-Feedback Display AzurePowershell Survey url for Resolve-Error Feb 6, 2020
@msJinLei msJinLei force-pushed the resolveerror branch 2 times, most recently from 7a94798 to ceac5a3 Compare February 7, 2020 09:05
@msJinLei
Copy link
Contributor Author

msJinLei commented Feb 7, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor Author

msJinLei commented Feb 7, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei msJinLei marked this pull request as ready for review February 7, 2020 19:48
@VeryEarly VeryEarly assigned VeryEarly and msJinLei and unassigned VeryEarly Feb 10, 2020
@msJinLei msJinLei force-pushed the resolveerror branch 2 times, most recently from 34a165a to ee8eaeb Compare February 10, 2020 12:20
@msJinLei
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei msJinLei force-pushed the resolveerror branch 2 times, most recently from 5eaa5b0 to 4a3f3fa Compare February 11, 2020 05:58
@msJinLei
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei msJinLei force-pushed the resolveerror branch 2 times, most recently from 89d32bb to efd9e86 Compare February 13, 2020 03:55
dingmeng-xue
dingmeng-xue reviewed Feb 13, 2020
View reviewed changes
src/Accounts/Accounts.Test/ErrorResolutionTests.cs Outdated
commandRuntime2.WriteInformation(informationRecord);
}

public override void ExecuteCmdlet()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to the reason why ExecuteCmdlet() method needs to be overridden.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to the reason why ExecuteCmdlet() method needs to be overridden.

Change the implementation by using a virtual method wrapping the WriteInformation.

@msJinLei msJinLei changed the base branch from master to release-2020-02-18 February 13, 2020 06:18
@msJinLei msJinLei force-pushed the resolveerror branch 2 times, most recently from f36c40c to d410e44 Compare February 13, 2020 10:01
@msJinLei msJinLei changed the base branch from release-2020-02-18 to master February 17, 2020 05:59
@msJinLei msJinLei closed this Feb 25, 2020
@msJinLei msJinLei deleted the resolveerror branch August 21, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingmeng-xue dingmeng-xue dingmeng-xue left review comments

Assignees

@msJinLei msJinLei

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msJinLei @dingmeng-xue @VeryEarly