Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Create a uber jar for maven #389

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Conversation

ag-ramachandran
Copy link
Contributor

Pull Request Description

There was an MSAL issue :
git push --set-upstream origin bugfix/UpgradeMSALLib](AzureAD/microsoft-authentication-library-for-java#806)

This fixes this issue that was reported

Copy link

github-actions bot commented Jul 10, 2024

Test Results

76 tests  ±0   76 ✅ ±0   2m 33s ⏱️ +6s
22 suites ±0    0 💤 ±0 
22 files   ±0    0 ❌ ±0 

Results for commit 445d507. ± Comparison against base commit 55eb2a0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@ohadbitt ohadbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also upgrade to the BOM version of Java SDK ?

@ag-ramachandran ag-ramachandran changed the title * Fix MSAL - 806 issue (https://github.com/AzureAD/microsoft-authenti… * Create a uber jar for maven Jul 13, 2024
@ag-ramachandran
Copy link
Contributor Author

Can we also upgrade to the BOM version of Java SDK ?

Sure Ohad, bumped the BOM here . Cherry picked changes on UBER jar packaging here as well

Copy link
Contributor

@ohadbitt ohadbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Bump version to 5.2.0 in POM
@ag-ramachandran ag-ramachandran merged commit 2b70b39 into master Jul 16, 2024
4 checks passed
@ag-ramachandran ag-ramachandran deleted the bugfix/UpgradeMSALLib branch July 16, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants