Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OneBox hostnames that include the port #417

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

yihezkel
Copy link
Member

@yihezkel yihezkel commented Feb 5, 2025

Fixed

Onebox URLs with port were rejected, and are now accepted.

Copy link

github-actions bot commented Feb 5, 2025

Test Results

332 tests  ±0   323 ✅ ±0   3m 35s ⏱️ -32s
 27 suites ±0     9 💤 ±0 
 27 files   ±0     0 ❌ ±0 

Results for commit 9e71c4b. ± Comparison against base commit 945e8e5.

♻️ This comment has been updated with latest results.

…d, use com.azure.core.util.CoreUtils instead
@yihezkel yihezkel merged commit 56e0446 into master Feb 12, 2025
8 checks passed
@yihezkel yihezkel deleted the sdkShouldWorkAgainstOneBoxWithPort branch February 12, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants