feat: Add in new support bundle work items #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tream/pipeline_int_tests
…ot-ops-cli-extension into upstream/pipeline_int_tests
|
btw - idk why there are commits from secret sync but those changes are not in the pr |
digimaun
reviewed
Feb 6, 2025
| @@ -78,6 +80,7 @@ def test_create_bundle_mq(init_setup, tracked_files, mq_traces): | |||
| check_workload_resource_files( | |||
| file_objs=file_map, | |||
| expected_workload_types=expected_workload_types, | |||
| prefixes=["aio-broker", "aio-dmqtt"], | |||
| prefixes=["aio-broker", "aio-dmqtt", "otel-collector-service"], | |||
There was a problem hiding this comment.
I haven't seen it but I want to keep it in just in case it pops up again...
digimaun
approved these changes
Feb 6, 2025
digimaun
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Items:
improve int testing for above
split out e2e vs rpsaas testing to avoid conflicts
prob some more qol changes
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.
Thank you for contributing to Azure IoT Operations tooling!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
devormainare of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrcand.flake8rules? Look at the CI scripts for example usage.Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).