Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration testing for az iot ops secretsync #475

Merged
merged 17 commits into from
Jan 16, 2025
Merged

Conversation

vilit1
Copy link
Contributor

@vilit1 vilit1 commented Jan 8, 2025

tests secret sync operations, including all inputs aside from --self-hosted-issuer. Also makes sure github action can test this

Notes:

  • az role assignment list has a retry since the command may fail (MI is created so it can be too new)
  • --self-hosted-issuer is not tested and is not used in the clean up operation. This will be fixed in the next pr (that will include direct calls to the cluster)

cluster with workload identity enabled but no secret sync:
image

cluster with workload identity enabled and secret sync already
image

cluster without workload identity:
image


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to Azure IoT Operations tooling!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@vilit1 vilit1 marked this pull request as ready for review January 10, 2025 23:57
@vilit1 vilit1 requested a review from digimaun as a code owner January 10, 2025 23:57
@vilit1
Copy link
Contributor Author

vilit1 commented Jan 13, 2025

https://github.com/Azure/azure-iot-ops-cli-extension/actions/runs/12719071171

note - the default failure is one ryan is going to fix in support bundle

@@ -16,6 +16,7 @@ class EnvironmentVariables(Enum):
instance = "azext_edge_instance"
context_name = "azext_edge_context_name"
kv = "azext_edge_kv"
user_assigned_mi_id = "azext_edge_user_assigned_mi_id"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this variable passed into / set in a pipeline somewhere, or how is it configured?

Copy link
Contributor Author

@vilit1 vilit1 Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no...
pipeline testing currently makes a new mi...
do I need to add in a pass through...
can I not...

@vilit1 vilit1 merged commit 73f72e2 into dev Jan 16, 2025
46 of 47 checks passed
@vilit1 vilit1 deleted the pipeline_int_tests branch February 5, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants