-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add integration testing for az iot ops secretsync
#475
Conversation
https://github.com/Azure/azure-iot-ops-cli-extension/actions/runs/12719071171 note - the default failure is one ryan is going to fix in support bundle |
@@ -16,6 +16,7 @@ class EnvironmentVariables(Enum): | |||
instance = "azext_edge_instance" | |||
context_name = "azext_edge_context_name" | |||
kv = "azext_edge_kv" | |||
user_assigned_mi_id = "azext_edge_user_assigned_mi_id" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this variable passed into / set in a pipeline somewhere, or how is it configured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no...
pipeline testing currently makes a new mi...
do I need to add in a pass through...
can I not...
tests secret sync operations, including all inputs aside from
--self-hosted-issuer
. Also makes sure github action can test thisNotes:
az role assignment list
has a retry since the command may fail (MI is created so it can be too new)--self-hosted-issuer
is not tested and is not used in the clean up operation. This will be fixed in the next pr (that will include direct calls to the cluster)cluster with workload identity enabled but no secret sync:

cluster with workload identity enabled and secret sync already

cluster without workload identity:

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.
Thank you for contributing to Azure IoT Operations tooling!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).