Let fatal exceptions when getting locked row count bubble up

[Charles-Gagnon]

Was investigating another issue and noticed that we were getting a number of exceptions like this :

Exception executing query. Message=Unable to acquire exclusive lock on _az_func_Trigger. Result = -999 You attempted to acquire a transactional application lock without an active transaction.

When trying to run the "Acquire leases" command. This shouldn't be possible, since I verified that we always open a transaction at the beginning of each loop iteration. But looking into it I realized that this could happen if an exception occurred during the GetLeaseLockedRowCount command. During that we ignore exceptions that occur (since it's just for debuggability) and so if we got in a situation where the exception was fatal it would cause issues like this.

The fix for this was twofold - first was to let the exceptions bubble up. But the current fatal logic wouldn't handle the specific issue I was seeing with the deadlock, since that isn't fatal for the connection (it's still open and usable). What it does do though is end the transaction - which means that all other queries will fail since a transaction is required for the app lock statement.

So I'm fixing it to let the exception bubble up so at least we don't get the noisy extra errors. This doesn't solve the deadlock problem at all - that's the thing I'm still currently investigating.