Fix build pipelines #1142
Merged
Fix build pipelines #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
chlafreniere,
MaddyDev and
VasuBhog
as code owners
MaddyDev
approved these changes
Nov 4, 2024
This reverts commit 298bb31.
MaddyDev
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixing expressions and runtime values will cause problems - and in this case I was using an expression in the wrapper template in the ADO repo so this template wasn't working as expected.
The PR build doesn't use the wrapper template, which is why this wasn't caught in PR earlier.
Using compile time expressions is clearer and more straightforward so switching to be consistent with using that for testServer.
Changing this then broke the PR pipeline though, since it was using the matrix build options which are evaluated at runtime (so the templates had an empty value when they evaluated the expressions). I briefly tried fixing the templates to use runtime values directly since theoretically those should work, but it was taking too long so I just changed the PR pipeline to not use the matrix build functionality and instead hardcode a job for each platform. This is what we do for the other pipelines anyways so there's some advantage with having all the pipelines be aligned anyways.
Buddy build : https://msdata.visualstudio.com/SQLToolsAndLibraries/_build/results?buildId=148012457&view=results