fix: catching unhandled exception for httpv2 / db #1494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using SDK type bindings, a user might put an invalid connection string setting. There might be a typo in the variable name, or they didn't add it as an app setting. Creating a client will fail and an exception will be thrown from the
azure-storage-blob
SDK in this scenario. In the invocation request, the except clause will be hit. However, sincehttp_v2_enabled
was not yet defined (previously defined after thefrom_incoming_proto
call), another exception will occur. That is an uncaught exception, and the function invocation will time out without any error messaging.The fix is to move the
http_v2_enabled
definition to abovefrom_incoming_proto
, so that iffrom_incoming_proto
failshttp_v2_enabled
will be set accordingly andset_http_response
can execute.However, if an exception occurs when setting
http_v2_enabled
(inget_function
orhttp_v2_enabled
), the same issue would occur. Thereforehttp_v2_enabled
is given a default value at the start of the invocation request.Fixes #
PR information
Quality of Code and Contribution Guidelines