Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catching unhandled exception for httpv2 / db #1494

Merged
merged 3 commits into from
May 28, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented May 13, 2024

Description

When using SDK type bindings, a user might put an invalid connection string setting. There might be a typo in the variable name, or they didn't add it as an app setting. Creating a client will fail and an exception will be thrown from the azure-storage-blob SDK in this scenario. In the invocation request, the except clause will be hit. However, since http_v2_enabled was not yet defined (previously defined after the from_incoming_proto call), another exception will occur. That is an uncaught exception, and the function invocation will time out without any error messaging.

The fix is to move the http_v2_enabled definition to above from_incoming_proto, so that if from_incoming_proto fails http_v2_enabled will be set accordingly and set_http_response can execute.

However, if an exception occurs when setting http_v2_enabled (in get_function or http_v2_enabled), the same issue would occur. Therefore http_v2_enabled is given a default value at the start of the invocation request.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria marked this pull request as ready for review May 13, 2024 19:48
@hallvictoria hallvictoria merged commit b0bacf0 into dev May 28, 2024
61 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/exception-bug branch May 28, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants