Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueprint change: worker indexing functionregister #1065

Merged
merged 6 commits into from
Jul 1, 2022

Conversation

YunchuWang
Copy link
Member

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@YunchuWang YunchuWang force-pushed the wangbill/blueprint branch from e09aa6a to c8509c7 Compare June 23, 2022 15:32
@YunchuWang YunchuWang force-pushed the wangbill/blueprint branch from c8509c7 to 2796ae8 Compare June 30, 2022 19:39
@YunchuWang YunchuWang marked this pull request as ready for review June 30, 2022 19:52
@YunchuWang YunchuWang force-pushed the wangbill/blueprint branch from 2796ae8 to 3a1f8bd Compare June 30, 2022 19:56
@YunchuWang YunchuWang force-pushed the wangbill/blueprint branch from 3a1f8bd to 8357066 Compare June 30, 2022 19:56
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1065 (4593265) into dev (f3ec8a9) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##              dev    #1065   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files          33       33           
  Lines        1778     1778           
  Branches      282      282           
=======================================
  Hits         1484     1484           
  Misses        230      230           
  Partials       64       64           
Flag Coverage Δ
unittests 83.46% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/loader.py 84.52% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f51a1f1...4593265. Read the comment docs.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One small comment only for future.

azure_functions_worker/loader.py Show resolved Hide resolved
@YunchuWang YunchuWang merged commit 1b52d72 into dev Jul 1, 2022
@YunchuWang YunchuWang deleted the wangbill/blueprint branch July 1, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants