Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blob generic binding tests. #1030

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Conversation

pdthummar
Copy link
Contributor

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1030 (fd3d1ef) into dev (c5888b1) will decrease coverage by 52.54%.
The diff coverage is n/a.

❗ Current head fd3d1ef differs from pull request most recent head 1063e8c. Consider uploading reports for the commit 1063e8c to get more accurate results

@@             Coverage Diff             @@
##              dev    #1030       +/-   ##
===========================================
- Coverage   84.01%   31.47%   -52.55%     
===========================================
  Files          34       34               
  Lines        1858     1846       -12     
  Branches      299      299               
===========================================
- Hits         1561      581      -980     
- Misses        232     1264     +1032     
+ Partials       65        1       -64     
Flag Coverage Δ
unittests 31.47% <ø> (-52.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_functions_worker/bindings/nullable_converters.py 21.62% <0.00%> (-78.38%) ⬇️
azure_functions_worker/functions.py 23.72% <0.00%> (-72.32%) ⬇️
azure_functions_worker/dispatcher.py 19.20% <0.00%> (-69.93%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
azure_functions_worker/utils/dependency.py 32.57% <0.00%> (-60.61%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
azure_functions_worker/extension.py 43.92% <0.00%> (-55.16%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-54.91%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5888b1...1063e8c. Read the comment docs.

@pdthummar pdthummar changed the title added blob generic binding tests. add blob generic binding tests. May 13, 2022
@YunchuWang YunchuWang force-pushed the pthummar/blob_generic_binding_tests branch from 21a9561 to 4154d86 Compare June 2, 2022 21:08
@YunchuWang YunchuWang force-pushed the pthummar/blob_generic_binding_tests branch from 4154d86 to b062d9b Compare June 14, 2022 15:48
@YunchuWang YunchuWang force-pushed the pthummar/blob_generic_binding_tests branch from 3313276 to 47a8219 Compare July 1, 2022 15:45
@pdthummar pdthummar merged commit 7afe38f into dev Jul 25, 2022
@pdthummar pdthummar deleted the pthummar/blob_generic_binding_tests branch July 25, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants