fix: add support for PEP 585 type hinting for 3.9+ #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunchuWang
requested review from
vrdmr,
gavin-aguiar and
pdthummar
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #199 +/- ##
==========================================
+ Coverage 92.97% 92.98% +0.01%
==========================================
Files 56 56
Lines 3187 3194 +7
Branches 649 651 +2
==========================================
+ Hits 2963 2970 +7
Misses 137 137
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hallvictoria
changed the title
| """ | ||
| origin = get_origin(annotation) | ||
| if sys.version_info >= (3, 9): | ||
| is_iterable_anno = (origin is not None |
There was a problem hiding this comment.
Why is typing_inspect.is_generic_type(annotation) not included in >3.9?
There was a problem hiding this comment.
is_generic_type will fail for the list type -- this is a method we defined. get_origin expands on our definition of is_generic_type but includes the built-in collection types. get_origin supports the generic types and returns a non-None value where is_generic_type would return true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces compatibility with PEP 585 type hinting in the Azure Functions Python Worker. PEP 585, introduced in Python 3.9, allows for the use of built-in collection types (like list and dict) as generic type hints, offering a more concise and readable syntax.
addressing Azure/azure-functions-python-worker#1034