Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GH#107: Enable support for multiple Set-Cookie response headers (native & wsgi/asgi) #115

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Apr 7, 2022

Part of change to address #107
Related change in worker: Azure/azure-functions-python-worker#1004

Changes

  1. Make HttpResponseHeader inherit from werkzeug header class which is also used in Flask, the header class has dict-like interface but is ordered and can store the same keys multiple times, all operations are case insensitive on header key.
  2. Cookie headers are extracted from httpresponseheaders and sent to worker as cookie field in rpchttp message.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #115 (b99ed62) into dev (990bb95) will increase coverage by 0.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #115      +/-   ##
==========================================
+ Coverage   85.00%   85.61%   +0.61%     
==========================================
  Files          47       47              
  Lines        2774     2781       +7     
  Branches      371      374       +3     
==========================================
+ Hits         2358     2381      +23     
+ Misses        341      324      -17     
- Partials       75       76       +1     
Flag Coverage Δ
unittests 85.61% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure/functions/_abc.py 75.82% <100.00%> (+0.08%) ⬆️
azure/functions/_http.py 91.30% <100.00%> (+6.95%) ⬆️
azure/functions/http.py 51.38% <100.00%> (+16.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990bb95...b99ed62. Read the comment docs.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left some comments and we can discuss offline to go over the details.

azure/functions/_abc.py Outdated Show resolved Hide resolved
azure/functions/_http.py Show resolved Hide resolved
azure/functions/http.py Show resolved Hide resolved
azure/functions/http.py Outdated Show resolved Hide resolved
azure/functions/http.py Outdated Show resolved Hide resolved
@YunchuWang YunchuWang force-pushed the wangbill/multi-dict branch from fac0e9e to 7816423 Compare April 20, 2022 18:53
@YunchuWang YunchuWang force-pushed the wangbill/multi-dict branch from 7816423 to e487530 Compare April 21, 2022 19:10
@YunchuWang YunchuWang requested a review from vrdmr April 21, 2022 19:19
@YunchuWang YunchuWang merged commit 60e7d69 into dev Apr 21, 2022
@YunchuWang YunchuWang deleted the wangbill/multi-dict branch April 21, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants