Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address pyspec feedback for new programming model #112

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Address pyspec feedback for new programming model #112

merged 2 commits into from
Apr 20, 2022

Conversation

YunchuWang
Copy link
Member

Changes involving:

  1. FunctionApp init auth_level -> http_auth_level
  2. FunctionApp init remove app_kwargs
  3. FunctionApp init change asgi_app/wsgi_app to kwargs
  4. Remove data type from route
  5. Change all trigger decorators to noun naming

@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Merging #112 (372a799) into dev (4bb65c1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #112      +/-   ##
==========================================
+ Coverage   84.65%   84.67%   +0.01%     
==========================================
  Files          46       46              
  Lines        2717     2714       -3     
  Branches      363      363              
==========================================
- Hits         2300     2298       -2     
  Misses        343      343              
+ Partials       74       73       -1
Flag Coverage Δ
unittests 84.67% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure/functions/decorators/function_app.py 99.21% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb65c1...372a799. Read the comment docs.

@YunchuWang YunchuWang changed the title Address pyspec feedback Address pyspec feedback for new programming model Mar 30, 2022
@YunchuWang YunchuWang marked this pull request as ready for review March 30, 2022 23:57
@YunchuWang
Address pyspec feedback
8579b2c 
Changes involving:
1. FunctionApp __init__ auth_level -> http_auth_level
2. FunctionApp __init__  remove app_kwargs
3. FunctionApp __init__ change asgi_app/wsgi_app to kwargs
4. Remove data type from route
5. Change all trigger decorators to noun naming
@YunchuWang YunchuWang force-pushed the wangbill/pystein-feedback branch from 134636f to 8579b2c Compare April 13, 2022 15:21
vrdmr
vrdmr approved these changes Apr 18, 2022
View reviewed changes
azure/functions/decorators/function_app.py
self._auth_level = AuthLevel[http_auth_level] \
if isinstance(http_auth_level, str) else http_auth_level

wsgi_app = kwargs.get("wsgi_app", None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - making it a hidden feature :)

@vrdmr vrdmr mentioned this pull request Apr 19, 2022
Merged
@YunchuWang YunchuWang merged commit 04ea33b into dev Apr 20, 2022
@YunchuWang YunchuWang deleted the wangbill/pystein-feedback branch April 20, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrdmr vrdmr vrdmr approved these changes

@gavin-aguiar gavin-aguiar Awaiting requested review from gavin-aguiar gavin-aguiar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YunchuWang @vrdmr