-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing fields in timer object. #110
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #110 +/- ##
==========================================
+ Coverage 84.39% 84.66% +0.26%
==========================================
Files 46 46
Lines 2711 2719 +8
Branches 363 363
==========================================
+ Hits 2288 2302 +14
+ Misses 349 343 -6
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
LGTM
@@ -5,19 +5,29 @@ | |||
import typing | |||
|
|||
from azure.functions import _abc as azf_abc | |||
|
|||
from . import meta | |||
|
|||
|
|||
class TimerRequest(azf_abc.TimerRequest): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YunchuWang - Getting your input here - If we plan to add PyDocs here - what could we add here?
@pdthummar No need to worry in this PR (mostly). But we should explore adding more PyDoc comments as they eventually show up in azure.functions.timerrequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrdmr would suggest giving a overview what this class does, adding definition of each field in init, and link to https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-timer?tabs=in-process&pivots=programming-language-java#attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am still unable to access those properties. When I use
When I use
|
@lak-amith531 If you are using old Coretools version, Can you please upgrade it to latest version and try it? It should work with latest version. If you are still facing issue after upgrading version, please create an issue with including replication steps. Thanks |
this doesn't work when schedule is more frequent than 1x p/min, even when useMonitor is set to true in function.json |
Added missing fields in timer object.
Fixes: Azure/azure-functions-python-worker#681
Fixes: Azure/azure-functions-python-worker#858