Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic binding decorators/Modify existing decorators to enable decorator extensibility under new programming model #108

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Add generic binding decorators/Modify existing decorators to enable decorator extensibility under new programming model #108

merged 3 commits into from
Apr 21, 2022

Conversation

YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Mar 23, 2022 •
edited
Loading

Add custom trigger, input and output bindings.

@codecov
Copy link

codecov bot commented Mar 23, 2022 •
edited
Loading

Codecov Report

Merging #108 (443e02f) into dev (04ea33b) will increase coverage by 0.33%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##              dev     #108      +/-   ##
==========================================
+ Coverage   84.67%   85.00%   +0.33%     
==========================================
  Files          46       47       +1     
  Lines        2714     2774      +60     
  Branches      363      371       +8     
==========================================
+ Hits         2298     2358      +60     
+ Misses        343      341       -2     
- Partials       73       75       +2
Flag Coverage Δ
unittests 85.00% <97.36%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure/functions/decorators/blob.py 100.00% <ø> (ø)
azure/functions/decorators/cosmosdb.py 100.00% <ø> (ø)
azure/functions/decorators/eventhub.py 100.00% <ø> (ø)
azure/functions/decorators/http.py 100.00% <ø> (ø)
azure/functions/decorators/queue.py 100.00% <ø> (ø)
azure/functions/decorators/servicebus.py 100.00% <ø> (ø)
azure/functions/decorators/timer.py 100.00% <ø> (ø)
azure/functions/decorators/function_app.py 98.59% <94.11%> (-0.62%) ⬇️
azure/functions/decorators/core.py 98.61% <100.00%> (+2.95%) ⬆️
azure/functions/decorators/generic.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ea33b...443e02f. Read the comment docs.

@YunchuWang YunchuWang marked this pull request as ready for review March 24, 2022 00:26
vrdmr
vrdmr reviewed Apr 1, 2022
View reviewed changes
azure/functions/decorators/http.py Outdated Show resolved Hide resolved
docs/ProgModelSpec.pyi Show resolved Hide resolved
azure/functions/decorators/core.py Show resolved Hide resolved
tests/decorators/test_core.py Show resolved Hide resolved
@YunchuWang YunchuWang requested a review from vrdmr April 1, 2022 15:02
@YunchuWang YunchuWang changed the title Add generic bindings Add generic binding decorators/Modify existing decorators to enable decorator extensibility under new programming model Apr 13, 2022
vrdmr
vrdmr reviewed Apr 14, 2022
View reviewed changes
azure/functions/decorators/core.py Outdated Show resolved Hide resolved
azure/functions/decorators/custom.py Outdated Show resolved Hide resolved
azure/functions/decorators/custom.py Outdated Show resolved Hide resolved
azure/functions/decorators/utils.py Show resolved Hide resolved
tests/decorators/test_core.py Outdated Show resolved Hide resolved
tests/decorators/test_custom.py Outdated Show resolved Hide resolved
azure/functions/decorators/function_app.py Outdated Show resolved Hide resolved
@YunchuWang YunchuWang requested a review from vrdmr April 15, 2022 13:57
vrdmr
vrdmr approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ship

azure/functions/decorators/core.py Show resolved Hide resolved
azure/functions/decorators/core.py Show resolved Hide resolved
azure/functions/decorators/custom.py Outdated Show resolved Hide resolved
azure/functions/decorators/core.py Outdated Show resolved Hide resolved
azure/functions/decorators/function_app.py Outdated Show resolved Hide resolved
@YunchuWang YunchuWang force-pushed the wangbill/generic-binding branch from 575b537 to e0130bf Compare April 20, 2022 18:50
@YunchuWang YunchuWang force-pushed the wangbill/generic-binding branch from e0130bf to c871fdc Compare April 20, 2022 21:06
@YunchuWang YunchuWang requested a review from vrdmr April 20, 2022 23:23
vrdmr
vrdmr approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@YunchuWang YunchuWang merged commit 990bb95 into dev Apr 21, 2022
@YunchuWang YunchuWang deleted the wangbill/generic-binding branch April 21, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-aguiar gavin-aguiar gavin-aguiar left review comments

@vrdmr vrdmr vrdmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YunchuWang @vrdmr @gavin-aguiar