Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hosting config support to control 3.x log disablement #10552

Merged
merged 10 commits into from
Dec 11, 2024

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Oct 21, 2024

Issue describing the changes in this PR

resolves #10546

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Logs pre-configuration (during host startup) are unrestricted.

Post-configuration, the log prefixes are determined by the following settings:

  • DisableHostLogs is true, FeatureFlag is not set, should result in restricted system log category prefixes
    • This is the only setting that would result in restricted logs.
  • DisableHostLogs is true, FeatureFlag is set, should result in unrestricted system log category prefixes
  • DisableHostLogs is false, FeatureFlag is not set, should result in unrestricted system log category prefixes
    • This is the Default host state.
  • DisableHostLogs is false, FeatureFlag is set, should result in unrestricted system log category prefixes

@liliankasem liliankasem force-pushed the liliankasem/v3/hostlogconfig branch 2 times, most recently from 6ef92cd to 7383f7b Compare October 21, 2024 23:17
@liliankasem liliankasem force-pushed the liliankasem/v3/hostlogconfig branch from 9087929 to de19d65 Compare October 24, 2024 20:56
@liliankasem liliankasem reopened this Oct 28, 2024
src/WebJobs.Script/ScriptConstants.cs Outdated Show resolved Hide resolved
@liliankasem liliankasem force-pushed the liliankasem/v3/hostlogconfig branch 3 times, most recently from 6da31a4 to e65a5a4 Compare October 31, 2024 17:26
@liliankasem liliankasem force-pushed the liliankasem/v3/hostlogconfig branch from 35b9168 to 2a258d0 Compare December 5, 2024 00:40
@liliankasem liliankasem force-pushed the liliankasem/v3/hostlogconfig branch from 9befe08 to 09a37c6 Compare December 11, 2024 01:51
@fabiocav fabiocav merged commit 7803096 into v3.x Dec 11, 2024
10 checks passed
@fabiocav fabiocav deleted the liliankasem/v3/hostlogconfig branch December 11, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants