Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Update project dependencies to latest #10551

Merged

Conversation

v-imohammad
Copy link
Contributor

@v-imohammad v-imohammad commented Oct 21, 2024

Adding pull request #10516 on top of 4.636.x and 4.836.x

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@v-imohammad v-imohammad requested a review from a team as a code owner October 21, 2024 18:54
@Francisco-Gamino
Copy link
Contributor

@v-imohammad - Please add an entry for the release notes. You can use the following:
Update project dependencies to the latest versions.

Otherwise, LTGM. Thank you.

@Francisco-Gamino Francisco-Gamino self-requested a review October 21, 2024 19:25
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding the entry in the release notes, we should be good to go.

@Francisco-Gamino
Copy link
Contributor

Please change the PR title to: [Hotfix] Update project dependencies to latest. After this, we are good to merge the PR.

Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider adding this to a hotfix branch instead.

@v-imohammad v-imohammad changed the base branch from release/in-proc to release/in-proc-hotfix-v4.x36.x October 21, 2024 21:07
@fabiocav
Copy link
Member

fabiocav commented Oct 21, 2024

Can you please make sure this is targeting a more specific branch (e.g., release/in-proc-hotfix-4.x36.<actualpatch> this should eventually be replaced by a tag only, but in the meantime, having the branch will avoid problems with the release flow.

@v-imohammad v-imohammad changed the title Adding commit #10516 on top of 4.636.x and 4.836.x [Hotfix] Update project dependencies to latest 4.636.x and 4.836.x Oct 21, 2024
@v-imohammad v-imohammad changed the base branch from release/in-proc-hotfix-v4.x36.x to release/in-proc-hotfix-v4.36.2 October 21, 2024 22:19
@v-imohammad v-imohammad changed the title [Hotfix] Update project dependencies to latest 4.636.x and 4.836.x [Hotfix] Update project dependencies to latest 4.36.2 in In-proc Oct 21, 2024
@Francisco-Gamino
Copy link
Contributor

@fabiocav - We have updated the PR. Could you please take a look? Thank you.

@fabiocav fabiocav changed the title [Hotfix] Update project dependencies to latest 4.36.2 in In-proc [Hotfix] Update project dependencies to latest Oct 22, 2024
@v-imohammad v-imohammad merged commit 2a4243c into release/in-proc-hotfix-v4.36.2 Oct 23, 2024
6 checks passed
@v-imohammad v-imohammad deleted the developer/v-imohammad/HFimage branch October 23, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants