Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging all required commits from in-proc into release/in-proc #10289

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Merging all required commits from in-proc into release/in-proc #10289

merged 4 commits into from
Jul 16, 2024

Conversation

v-imohammad
Copy link
Contributor

@v-imohammad v-imohammad commented Jul 15, 2024 •
edited
Loading

Added following commit to release/in-proc branch from In-proc

  1. JIT Trace - 4.35.0 using in-proc as base
  2. [in-proc] Adding a timeout to IFunctionProvider.GetFunctionMetadataAsync
  3. [[in-proc port] Ensure extension RPC endpoints ready before processing gRPC messages
  4. [[in-proc] Update Microsoft.Azure.WebJobs to 3.0.41 and Microsoft.Azure.WebJobs.Host.Storage to 5.0.1

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

v-imohammad and others added 4 commits July 15, 2024 16:20
@v-imohammad
JIT Trace - 4.35.0 using in-proc as base (#10281)
9361986
@kshyju @v-imohammad
Adding a timeout to IFunctionProvider.GetFunctionMetadataAsync (#10249
6e0e94b 
) (#10273)

* Adding a timeout to IFunctionProvider.GetFunctionMetadataAsync so that if a provider does not return, it will not cause a deadlock state.

* Adding release notes.

* Added a new internal property `MetadataProviderTimeoutInSeconds` which can be set to a different value than default, from the tests.

* Added comment about property being settable.

* PR feedback fixes. Throws an error when the function metadata provider method throws or when the operation timeseout.
@jviau @v-imohammad
[in-proc port] Ensure extension RPC endpoints ready before processing…
38dadd7 
… gRPC messages (#10282)

* Ensure extension RPC endpoints ready before processing gRPC messages (#10255)

* Ensure extension RPC endpoints ready before processing gRPC messages

* Add timeout and tests to waiting on RPC extensions.

* update release_notes.md
@kshyju @v-imohammad
[in-proc] Update Microsoft.Azure.WebJobs to 3.0.41 and Microsoft.Azur…
f30bd93 
…e.WebJobs.Host.Storage to 5.0.1 (#10288)

* Upgraded the following package versions:
  - Microsoft.Azure.WebJobs updated to 3.0.41
  - Microsoft.Azure.WebJobs.Host.Storage updated to 5.0.1
  - Microsoft.Extensions.Azure updated to 1.7.1
  - Azure.Storage.Blobs updated to 12.19.1

* Updating deps.json for Tests.
@kshyju
Copy link
Member

kshyju commented Jul 16, 2024 •
edited
Loading

Please update the PR title to include information about the release.

@v-imohammad v-imohammad merged commit 32cf5a4 into release/in-proc Jul 16, 2024
10 checks passed
@v-imohammad v-imohammad deleted the u/v-imohammad/4.35.0mergedcommit branch July 16, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliaslopezgt eliaslopezgt eliaslopezgt approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr

@pragnagopa pragnagopa Awaiting requested review from pragnagopa

@VpOfEngineering VpOfEngineering Awaiting requested review from VpOfEngineering

Assignees
No one assigned
Labels
Needs: Author Feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-imohammad @kshyju @eliaslopezgt @jviau