Updating coretools to detect unsupported inproc6 sdk scenario

src/Azure.Functions.Cli/Actions/HostActions/StartHostAction.cs

@@ -494,8 +494,16 @@ private async Task<bool> ShouldExitAfterDeterminingHostRuntime(bool isVerbose)
 
                 if (!string.Equals(HostRuntime, "default", StringComparison.OrdinalIgnoreCase))
                 {
-                    var isNet8InProcSpecified = string.Equals(HostRuntime, DotnetConstants.InProc8HostRuntime, StringComparison.OrdinalIgnoreCase);
-                    StartHostAsChildProcess(isNet8InProcSpecified);
+                    if (Utilities.IsMinifiedVersion())
+                    {
+                        ThrowIfInProc();
+                    }
+                    else
+                    {
+                        var isNet8InProcSpecified = string.Equals(HostRuntime, DotnetConstants.InProc8HostRuntime, StringComparison.OrdinalIgnoreCase);
+                        StartHostAsChildProcess(isNet8InProcSpecified);
+                    }
+
                     return true;
                 }
             }
@@ -514,7 +522,14 @@ private async Task<bool> ShouldExitAfterDeterminingHostRuntime(bool isVerbose)
                     PrintVerboseForHostSelection(isVerbose, DotnetConstants.InProc6HostRuntime);
                 }
 
-                StartHostAsChildProcess(shouldNet8InProcBeLaunched);
+                if (Utilities.IsMinifiedVersion())
+                {
+                    ThrowIfInProc();
+                }
+                else
+                {
+                    StartHostAsChildProcess(shouldNet8InProcBeLaunched);
+                }
                 return true;
 
             }
@@ -571,6 +586,10 @@ private async Task ValidateHostRuntime(bool isInProc, bool isVerbose)
             throw new CliException($"Invalid host runtime '{HostRuntime}'. Valid values are 'default', '{DotnetConstants.InProc8HostRuntime}', '{DotnetConstants.InProc6HostRuntime}'.");
         }
 
+        private void ThrowIfInProc()
+        {
+            throw new CliException($"This version of the Azure Functions Core Tools requires your project to reference version {DotnetConstants.InProcFunctionsMinSdkVersion} or later of {DotnetConstants.InProcFunctionsSdk}. Please update to the latest version. For more information, see: {DotnetConstants.InProcFunctionsDocsLink}");
+        }
         private void PrintVerboseForHostSelection(bool isVerbose, string hostRuntime)
         {
             if (isVerbose)

src/Azure.Functions.Cli/ArtifactsConfigurationBuilder.cs

@@ -0,0 +1,19 @@
+using Azure.Functions.Cli.Common;
+using Microsoft.Azure.WebJobs.Script;
+using Microsoft.Extensions.Configuration;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Azure.Functions.Cli
+{
+    internal class ArtifactsConfigurationBuilder : IConfigureBuilder<IConfigurationBuilder>
+    {
+        public void Configure(IConfigurationBuilder builder)
+        {
+            builder.AddJsonFile(Constants.ArtifactsConfigFileName, optional: true);        
+        }
+    }
+}

src/Azure.Functions.Cli/Common/Constants.cs

@@ -26,6 +26,8 @@ internal static class Constants
         public const string HostJsonFileName = "host.json";
         public const string PackageJsonFileName = "package.json";
         public const string ProxiesJsonFileName = "proxies.json";
+        public const string ArtifactsConfigFileName = "artifactsconfig.json";
+        public const string MinifiedVersionConfigSectionName = "minifiedVersion";
         public const string ExtensionsCsProjFile = "extensions.csproj";
         public const string DefaultVEnvName = "worker_env";
         public const string ExternalPythonPackages = ".python_packages";

src/Azure.Functions.Cli/Common/DotnetConstants.cs

@@ -14,5 +14,8 @@ internal static class DotnetConstants
         public const string InProc6DirectoryName = "in-proc6";
         public const string InProc8HostRuntime = "inproc8";
         public const string InProc6HostRuntime = "inproc6";
+        public const string InProcFunctionsSdk = "Microsoft.NET.Sdk.Functions";
+        public const string InProcFunctionsMinSdkVersion = "4.5.0";
+        public const string InProcFunctionsDocsLink = "https://aka.ms/functions-core-tools-in-proc-sdk-requirement";
     }
 }

src/Azure.Functions.Cli/Common/Utilities.cs

@@ -263,5 +263,33 @@ internal static IConfigurationRoot BuildHostJsonConfigutation(ScriptApplicationH
             var configuration = builder.Build();
             return configuration;
         }
+
+        internal static bool IsMinifiedVersion()
+        {
+            var config = BuildArtifactsConfiguration();
+
+            try
+            {
+                var section = config.GetSection(Constants.MinifiedVersionConfigSectionName);
+
+                if (section.Exists())
+                {
+                    string value = section.Value;
+                    return bool.TryParse(value, out bool isValue) && isValue;
+                }
+            }
+            catch { }
+            return false;
+        }
+
+        internal static IConfigurationRoot BuildArtifactsConfiguration()
+        {
+            var configureBuilder = new ArtifactsConfigurationBuilder();
+            var configurationBuilder = new ConfigurationBuilder();
+            configureBuilder.Configure(configurationBuilder);
+            var root = configurationBuilder.Build();
+            return root;
+        }
+
     }
 }

test/Azure.Functions.Cli.Tests/E2E/StartTests.cs

@@ -454,7 +454,7 @@ await CliTester.Run(new RunConfiguration
                 {
                     using (var client = new HttpClient() { BaseAddress = new Uri("http://localhost:7073") })
                     {
-                        await Task.Delay(TimeSpan.FromSeconds(2));
+                        await Task.Delay(TimeSpan.FromSeconds(5));
                     }
                 },
                 CommandTimeout = TimeSpan.FromSeconds(300),
@@ -476,15 +476,15 @@ await CliTester.Run(new RunConfiguration
                 ErrorContains = ["Failed to locate the inproc6 model host at"],
                 Test = async (workingDir, p) =>
                 {
+
                     using (var client = new HttpClient() { BaseAddress = new Uri("http://localhost:7073") })
                     {
-                        await Task.Delay(TimeSpan.FromSeconds(2));
+                        await Task.Delay(TimeSpan.FromSeconds(5));
                     }
                 },
-                CommandTimeout = TimeSpan.FromSeconds(100),
+                CommandTimeout = TimeSpan.FromSeconds(300),
             }, _output);
         }
-
         [Fact]
         public async Task dont_start_inproc6_specified_runtime_for_dotnet_isolated()
         {
@@ -677,31 +677,6 @@ await CliTester.Run(new RunConfiguration
             }, _output);
         }
 
-        [Fact]
-        public async Task start_dotnet_isolated_inproc_with_specifying_runtime()
-        {
-            await CliTester.Run(new RunConfiguration
-            {
-                Commands = new[]
-                {
-                    "init . --worker-runtime dotnet --target-framework net6.0",
-                    "new --template Httptrigger --name HttpTrigger",
-                    "start --port 7073 --verbose --runtime inproc6"
-                },
-                ExpectExit = false,
-                ErrorContains = ["Failed to locate the inproc6 model host at"],
-                Test = async (workingDir, p) =>
-                {
-                    using (var client = new HttpClient() { BaseAddress = new Uri("http://localhost:7073") })
-                    {
-                        await Task.Delay(TimeSpan.FromSeconds(2));
-                    }
-                },
-                CommandTimeout = TimeSpan.FromSeconds(100),
-            }, _output);
-        }
-
-
         [Fact]
         public async Task start_dotnet_isolated_csharp_with_oop_host_with_runtime_specified()
         {

test/Azure.Functions.Cli.Tests/UtilitiesTests.cs

@@ -2,6 +2,7 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
 using System.Collections.Generic;
+using System.IO;
 using Xunit;
 
 namespace Azure.Functions.Cli.Tests
@@ -60,5 +61,20 @@ public void IsSystemLogCategory_Test(string inputCategory, bool expected)
         {
             Assert.Equal(expected, Utilities.IsSystemLogCategory(inputCategory));
         }
+
+        [Theory]
+        [InlineData(true)]
+        [InlineData(false)]
+        public void Test_IsMinifiedVersion(bool expected)
+        {
+            var filePath = Path.Combine("artifactsconfig.json");
+            string artifactsJsonContent = "{\"minifiedVersion\": " + expected.ToString().ToLower() + "}";
+            File.WriteAllTextAsync(filePath, artifactsJsonContent).GetAwaiter().GetResult();
+
+            bool output = Utilities.IsMinifiedVersion();
+
+            File.Delete(filePath);
+            Assert.Equal(expected, output);
+        }
     }
 }