Flex Deployment #3404
Merged
Flex Deployment #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamperiadis
requested changes
Aug 8, 2023
| @@ -7,7 +7,7 @@ namespace Azure.Functions.Cli.Arm | |||
| internal static class ArmUriTemplates | |||
| { | |||
| public const string ArmApiVersion = "2018-09-01"; | |||
| public const string WebsitesApiVersion = "2015-08-01"; | |||
| public const string WebsitesApiVersion = "2015-08-01";//"2022-03-01-privatepreview&stamp=eliasl-linux01geo.eastus.cloudapp.azure.com";//"2015-08-01"; | |||
There was a problem hiding this comment.
Do we still need the comment?
| } | ||
| else if (status == DeployStatus.Failed) | ||
| { | ||
| throw new CliException("The deployment failed, Please check the printed logs."); |
There was a problem hiding this comment.
We should print the deployment logs since the kudu instance will get recycled and there might be no way for customers to access the logs
There was a problem hiding this comment.
At this point, logs are already printed. Please search "// Safely printing logs after the status is confirmed." in the code.
| } | ||
| else if (status == DeployStatus.PartialSuccess) | ||
| { | ||
| ColoredConsole.WriteLine(WarningColor(GetLogMessage("\"Deployment was partially successful, Please check the printed logs."))); |
There was a problem hiding this comment.
Same thing as above. We should print the deployment logs since the kudu instance will get recycled and there might be no way for customers to access the logs
There was a problem hiding this comment.
Logs should already be printed at this stage.
nzthiago
reviewed
Aug 8, 2023
src/Azure.Functions.Cli/Actions/AzureActions/PublishFunctionAppAction.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist