Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Microsoft.Azure.AppService.Proxy for re-cert. #3312

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Adding Microsoft.Azure.AppService.Proxy for re-cert. #3312

merged 1 commit into from
Mar 16, 2023

Conversation

khkh-ms
Copy link
Contributor

@khkh-ms khkh-ms commented Mar 16, 2023

Issue describing the changes in this PR

Fixing the issue when wrong cert was used to sign a file.

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@khkh-ms khkh-ms requested a review from VpOfEngineering March 16, 2023 15:05
@khkh-ms khkh-ms merged commit 981aa2b into v4.x Mar 16, 2023
@khkh-ms khkh-ms deleted the khkh/certfix branch March 16, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VpOfEngineering VpOfEngineering VpOfEngineering approved these changes

@michaelpeng36 michaelpeng36 Awaiting requested review from michaelpeng36

@AnatoliB AnatoliB Awaiting requested review from AnatoliB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khkh-ms @VpOfEngineering