Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic PyStein support V4 #3071

Merged
merged 31 commits into from
Aug 29, 2022
Merged

Add basic PyStein support V4 #3071

merged 31 commits into from
Aug 29, 2022

Conversation

michaelpeng36
Copy link
Contributor

Issue describing the changes in this PR

Adds basic support (P0 functionalities) for the preview Python programming model. This PR is not to be merged until the appropriate version of the host is determined.

Pull request checklist

@michaelpeng36
Copy link
Contributor Author

/cc @gavin-aguiar @shreyabatra4 to address the unresolved conversations above

Copy link
Contributor

@ejizba ejizba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty much done reviewing at this point. Once the ProgrammingModel flags get updated I'll approve. Again, I'd vote for "v1" and "v2" unless someone comes up with a better idea - not very descriptive, but at least they're future-proof



RUN cd /home && \
git clone --branch gaaguiar/new-prg-model https://github.com/Azure/azure-functions-python-worker.git && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect the Python folks to review this file as I don't know much about it

At a minimum we should remove the reference to "gaaguiar" before merging

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavin-aguiar bringing this back up

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be updated now. We can use the latest release from the python worker repo.

@michaelpeng36 michaelpeng36 merged commit 68d84ae into v4.x Aug 29, 2022
@michaelpeng36 michaelpeng36 deleted the michaelpeng/pystein-v4 branch August 29, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants