Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port "Update Node.js package.json templates for func init" to v3.x #2853

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Port "Update Node.js package.json templates for func init" to v3.x #2853

merged 2 commits into from
Dec 2, 2021

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Dec 2, 2021

Only difference is @azure/functions version should be 2 instead of 3 (see here for versioning info)

Original PR: #2852

michaelpeng36
michaelpeng36 approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@michaelpeng36 michaelpeng36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejizba ejizba merged commit 7e8b7bd into v3.x Dec 2, 2021
@ejizba ejizba deleted the ej/portPackageJson branch December 2, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpeng36 michaelpeng36 michaelpeng36 approved these changes

@AnatoliB AnatoliB Awaiting requested review from AnatoliB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejizba @michaelpeng36