Fix connection, link and timer object leaks after EntityClose & fix inaccurate timer issues #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SreeramGarlapati
commented
Mar 30, 2017
SreeramGarlapati
commented
- fixes stuck behaviors in Sender & Receiver
- MsgReceiver should update the pendingReceive queue before enqueing work to ReactorDispatcher
- fix receiver when prefetch queue is full
- Fix Sender & Receiver dormant links after close
- move messagesender timer out-of reactorDispatcher queue
- handle scenarios where an underlying linkOpen is pending and user invokes receiver.close()
- fix the close paths for send - for dormant links
- Move link open close timers out of ReactorDispatcher
- Clear pendingSends & Receives in case of CloseTimeout
- Don't open amqpconnection if MsgFactory is in Closed() state
* fixes stuck behaviors in Sender & Receiver * MsgReceiver should update the pendingReceive queue before enqueing work to ReactorDispatcher * fix receiver when prefetch queue is full * Fix Sender & Receiver dormant links after close * move messagesender timer out-of reactorDispatcher queue * handle scenarios where an underlying linkOpen is pending and user invokes receiver.close() * fix the close paths for send - for dormant links * Move link open close timers out of ReactorDispatcher * Clear pendingSends & Receives in case of CloseTimeout * Don't open amqpconnection if MsgFactory is in Closed() state
|
@SreeramGarlapati, |
|
@sjkwak @JamesBirdsall - I redirected our stress runs to run against this branch - lets wait on the stress results to merge this PR... |
SreeramGarlapati
changed the title
…narios effectively
sjkwak
reviewed
Apr 3, 2017
| @@ -210,6 +216,8 @@ public void onOpenComplete(Exception exception) | |||
| { | |||
| this.open.complete(this); | |||
| this.openConnection.complete(this.connection); | |||
| if (this.getIsClosingOrClosed()) | |||
| this.connection.close(); | |||
There was a problem hiding this comment.
Shouldn't we also stop a reactor in case we close a connection?
There was a problem hiding this comment.
Yes, we should & We already Do.
"Close-Connection" is a reactor event - which will need to flown to service. Once, client gets close ack from service, reactor will invoke onError(null) - which is equivalent to remoteClose - & in the OnError(null) - we stop the reactor.
In reply to: 109542770 [](ancestors = 109542770)
SreeramGarlapati
added a commit
to SreeramGarlapati/azure-event-hubs-java
that referenced
this pull request
Apr 6, 2017
…naccurate timer issues (Azure#88) * Fix connection, link and timer object leaks after EntityClose * fixes stuck behaviors in Sender & Receiver * MsgReceiver should update the pendingReceive queue before enqueing work to ReactorDispatcher * fix receiver when prefetch queue is full * Fix Sender & Receiver dormant links after close * move messagesender timer out-of reactorDispatcher queue * handle scenarios where an underlying linkOpen is pending and user invokes receiver.close() * fix the close paths for send - for dormant links * Move link open close timers out of ReactorDispatcher * Clear pendingSends & Receives in case of CloseTimeout * Don't open amqpconnection if MsgFactory is in Closed() state * Fix sender stuck issue due to a missing not(!) in if check * Fix dead links registered for ConnectionHandler errors * add manual test which can be used to test intermittent connection scanarios effectively * minor refactor * don't proactively throw sendlink error on token renewal failure * nit fixes * code refactor * refactoring messagesender * Update minor release * minor refactor
SwayGom
pushed a commit
that referenced
this pull request
May 17, 2024
…naccurate timer issues (#88) * Fix connection, link and timer object leaks after EntityClose * fixes stuck behaviors in Sender & Receiver * MsgReceiver should update the pendingReceive queue before enqueing work to ReactorDispatcher * fix receiver when prefetch queue is full * Fix Sender & Receiver dormant links after close * move messagesender timer out-of reactorDispatcher queue * handle scenarios where an underlying linkOpen is pending and user invokes receiver.close() * fix the close paths for send - for dormant links * Move link open close timers out of ReactorDispatcher * Clear pendingSends & Receives in case of CloseTimeout * Don't open amqpconnection if MsgFactory is in Closed() state * Fix sender stuck issue due to a missing not(!) in if check * Fix dead links registered for ConnectionHandler errors * add manual test which can be used to test intermittent connection scanarios effectively * minor refactor * don't proactively throw sendlink error on token renewal failure * nit fixes * code refactor * refactoring messagesender * Update minor release * minor refactor
SwayGom
pushed a commit
that referenced
this pull request
May 17, 2024
…naccurate timer issues (#88) * Fix connection, link and timer object leaks after EntityClose * fixes stuck behaviors in Sender & Receiver * MsgReceiver should update the pendingReceive queue before enqueing work to ReactorDispatcher * fix receiver when prefetch queue is full * Fix Sender & Receiver dormant links after close * move messagesender timer out-of reactorDispatcher queue * handle scenarios where an underlying linkOpen is pending and user invokes receiver.close() * fix the close paths for send - for dormant links * Move link open close timers out of ReactorDispatcher * Clear pendingSends & Receives in case of CloseTimeout * Don't open amqpconnection if MsgFactory is in Closed() state * Fix sender stuck issue due to a missing not(!) in if check * Fix dead links registered for ConnectionHandler errors * add manual test which can be used to test intermittent connection scanarios effectively * minor refactor * don't proactively throw sendlink error on token renewal failure * nit fixes * code refactor * refactoring messagesender * Update minor release * minor refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.