-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.12.0 #76
Release 0.12.0 #76
Conversation
…ure#65) * Optimization: flow the Receiver runtime info as part of EventData - Partition receiver runtime metrics aka EndOfStream info * move cursor to 0.12.0-snapshot * receiverruntimemetrics on PartitionReceiver & eph + junits * improve cit coverage
…ytes (Azure#71) * EventData deserialization fails when the payload size is >1000bytes * move to readFully api (suggestion from @CodingCat)
@SreeramGarlapati, |
waitForTelltale(settings); | ||
|
||
Assert.assertTrue(settings.outProcessorFactory.getOnEventsContext().getRuntimeInformation() != null); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "testFinish(settings, SmokeTest.ANY_NONZERO_COUNT);" at the end of this case. Otherwise, a run of all cases in this class will fail because this case will interfere with following ones. #Resolved
(please don't Squash merge - all individual commits would be lost) |
if (lastMessageRef != null && lastMessageRef.get() != null) { | ||
|
||
if (PartitionReceiver.this.runtimeInformation == null) | ||
PartitionReceiver.this.runtimeInformation = new ReceiverRuntimeInformation(PartitionReceiver.this.partitionId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (metric is enabled), let's set the runtime info..
|
||
if (lastMessageRef.get().getDeliveryAnnotations() != null && lastMessageRef.get().getDeliveryAnnotations().getValue() != null) { | ||
|
||
Map<Symbol, Object> deliveryAnnotationsMap = lastMessageRef.get().getDeliveryAnnotations().getValue(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lastMessageRef.get().getDeliveryAnnotations() [](start = 85, length = 45)
let's have a local variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* runtimeinfo: refactoring for CR * minor refactor * update eph test
* Optimization: flow the Receiver runtime info as part of EventData (#65) * Optimization: flow the Receiver runtime info as part of EventData - Partition receiver runtime metrics aka EndOfStream info * move cursor to 0.12.0-snapshot * receiverruntimemetrics on PartitionReceiver & eph + junits * improve cit coverage * Fix issue 58: deliver empty iterable to onEvents on timeout * fix: eventData deserialization error, when the payload size is >1000bytes (#71) * EventData deserialization fails when the payload size is >1000bytes * move to readFully api (suggestion from @CodingCat) * releaseChecklist: fix javadoc & update version to 0.12.0 (#73) * eph test fix - absorb all events sent by RuntimeInfotest to not effect other tests * runtimeinfo: refactoring for CR (#80) * runtimeinfo: refactoring for CR * minor refactor * update eph test * fix exception contract for link-detach errors - this should be a transient error (#78)
No description provided.