Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.12.0 #76

Merged
merged 7 commits into from
Mar 16, 2017
Merged

Release 0.12.0 #76

merged 7 commits into from
Mar 16, 2017

Conversation

SreeramGarlapati
Copy link
Contributor

No description provided.

SreeramGarlapati and others added 4 commits March 14, 2017 14:30
…ure#65)

* Optimization: flow the Receiver runtime info as part of EventData - Partition receiver runtime metrics aka EndOfStream info
* move cursor to 0.12.0-snapshot
* receiverruntimemetrics on PartitionReceiver & eph + junits

* improve cit coverage
…ytes (Azure#71)

* EventData deserialization fails when the payload size is >1000bytes
* move to readFully api (suggestion from @CodingCat)
@msftclas
Copy link

@SreeramGarlapati,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

waitForTelltale(settings);

Assert.assertTrue(settings.outProcessorFactory.getOnEventsContext().getRuntimeInformation() != null);
}
Copy link
Contributor

@JamesBirdsall JamesBirdsall Mar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "testFinish(settings, SmokeTest.ANY_NONZERO_COUNT);" at the end of this case. Otherwise, a run of all cases in this class will fail because this case will interfere with following ones. #Resolved

@SreeramGarlapati
Copy link
Contributor Author

(please don't Squash merge - all individual commits would be lost)

if (lastMessageRef != null && lastMessageRef.get() != null) {

if (PartitionReceiver.this.runtimeInformation == null)
PartitionReceiver.this.runtimeInformation = new ReceiverRuntimeInformation(PartitionReceiver.this.partitionId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (metric is enabled), let's set the runtime info..


if (lastMessageRef.get().getDeliveryAnnotations() != null && lastMessageRef.get().getDeliveryAnnotations().getValue() != null) {

Map<Symbol, Object> deliveryAnnotationsMap = lastMessageRef.get().getDeliveryAnnotations().getValue();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastMessageRef.get().getDeliveryAnnotations() [](start = 85, length = 45)

let's have a local variable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submitted a NEW PR for the feedback: #80


In reply to: 106258518 [](ancestors = 106258518)

* runtimeinfo: refactoring for CR

* minor refactor

* update eph test
@sjkwak sjkwak merged commit 180bc11 into Azure:master Mar 16, 2017
SwayGom pushed a commit that referenced this pull request May 17, 2024
* Optimization: flow the Receiver runtime info as part of EventData (#65)

* Optimization: flow the Receiver runtime info as part of EventData - Partition receiver runtime metrics aka EndOfStream info
* move cursor to 0.12.0-snapshot
* receiverruntimemetrics on PartitionReceiver & eph + junits

* improve cit coverage

* Fix issue 58: deliver empty iterable to onEvents on timeout

* fix: eventData deserialization error, when the payload size is >1000bytes (#71)

* EventData deserialization fails when the payload size is >1000bytes
* move to readFully api (suggestion from @CodingCat)

* releaseChecklist: fix javadoc & update version to 0.12.0 (#73)

* eph test fix - absorb all events sent by RuntimeInfotest to not effect other tests

* runtimeinfo: refactoring for CR (#80)

* runtimeinfo: refactoring for CR

* minor refactor

* update eph test

* fix exception contract for link-detach errors - this should be a transient error (#78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants