Fix for issue 3: checkpoint overwrite race #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re an extra storage call. Instead, cache the last written checkpoint and merge those values when an overwrite would otherwise occur.
|
Hi @JamesBirdsall, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
|
SreeramGarlapati
approved these changes
Nov 15, 2016
SwayGom
pushed a commit
that referenced
this pull request
May 17, 2024
Fix for issue 3: checkpoint overwrite race
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureStorageCheckpointLeaseManager.java is the important change. AzureBlobLease.java adds a utility function to support the change. The rest of it is test changes.
AzureStorageCheckpointLeaseManager now caches checkpoint writes as they happen, and if the upload of a serialized lease to storage has a lower offset/sequence number than the cached value, the cached value is merged before serialization and upload.