Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connectionImpl objects leak issue in scenarios when service closes connection #116

Merged
merged 9 commits into from
Jun 10, 2017
Merged

Fix connectionImpl objects leak issue in scenarios when service closes connection #116

merged 9 commits into from
Jun 10, 2017

Conversation

SreeramGarlapati
Copy link
Contributor

@SreeramGarlapati SreeramGarlapati commented Jun 2, 2017 •
edited
Loading

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).
  • If applicable, the public code is properly documented.
  • Pull request includes test coverage for the included changes.
  • The code builds without any errors.

@SreeramGarlapati SreeramGarlapati requested a review from sjkwak June 2, 2017 23:49
@SreeramGarlapati SreeramGarlapati changed the title Fix connection leak issue in scenarios when service closes connection Fix connectionImpl objects leak issue in scenarios when service closes connection Jun 9, 2017
@SreeramGarlapati SreeramGarlapati merged commit 7d41ca0 into Azure:dev Jun 10, 2017
SreeramGarlapati added a commit to SreeramGarlapati/azure-event-hubs-java that referenced this pull request Jun 27, 2017
@SreeramGarlapati
Fix connectionImpl objects leak issue in scenarios when service close…
78f70fd 
…s connection (Azure#116)

* free connectionImpl objects leak issue upon connection failures from service
* fix receive unit test
* skip connection.free in case when connection is not initialized
@SreeramGarlapati SreeramGarlapati added this to the 0.14.2 milestone Jun 28, 2017
@SreeramGarlapati SreeramGarlapati deleted the fix.connLeak branch June 28, 2017 21:36
sjkwak pushed a commit that referenced this pull request Jul 7, 2017
@SreeramGarlapati @sjkwak
Bring all changes from Master back to Dev (#140)
8c934b8 
* Cherry-picking PR119 and PR122 into master (#129)

* Handle StorageExceptions from AzureBlobLease.isExpired

* Improve notification experience for ExecutionExceptions

* Cherry-pick PR119, start cherry-picking PR122

* Finish cherry-picking PR122

* Remove partial change that was picked accidentally

* Add Javadocs for PartitionManagerOptions (#130)

* Handle StorageExceptions from AzureBlobLease.isExpired

* Improve notification experience for ExecutionExceptions

* Cherry-pick PR119, start cherry-picking PR122

* Finish cherry-picking PR122

* Remove partial change that was picked accidentally

* Add Javadoc for PartitionManangerOptions

* Undo merge problem

* Set versions to 0.14.0 except eph 0.14.1

* Special override for EPH version

* Fix connectionImpl objects leak issue in scenarios when service closes connection (#116)

* free connectionImpl objects leak issue upon connection failures from service
* fix receive unit test
* skip connection.free in case when connection is not initialized

* Adding Interface for EventHubClient class to enable mock testing

* add no-arg constructors for GSon serialized types (#112)


# Conflicts:
#	azure-eventhubs-eph/src/main/java/com/microsoft/azure/eventprocessorhost/AzureBlobLease.java

* split platform & framework while adding to connection properties (#124)

* Update version to 0.14.2

* bump up the version to 0.15.0

* add receiver identifier to ReceiverOptions

* minor refactor

* client version to 0.14.3

* Refresh token every 10 mins - to help with error situations

* javadoc for receiveridentifier (#138)
sjkwak pushed a commit that referenced this pull request Jul 7, 2017
@SreeramGarlapati @sjkwak
fix build break in eph due to merge from master (#141)
dc3d00c 
* Cherry-picking PR119 and PR122 into master (#129)

* Handle StorageExceptions from AzureBlobLease.isExpired

* Improve notification experience for ExecutionExceptions

* Cherry-pick PR119, start cherry-picking PR122

* Finish cherry-picking PR122

* Remove partial change that was picked accidentally

* Add Javadocs for PartitionManagerOptions (#130)

* Handle StorageExceptions from AzureBlobLease.isExpired

* Improve notification experience for ExecutionExceptions

* Cherry-pick PR119, start cherry-picking PR122

* Finish cherry-picking PR122

* Remove partial change that was picked accidentally

* Add Javadoc for PartitionManangerOptions

* Undo merge problem

* Set versions to 0.14.0 except eph 0.14.1

* Special override for EPH version

* Fix connectionImpl objects leak issue in scenarios when service closes connection (#116)

* free connectionImpl objects leak issue upon connection failures from service
* fix receive unit test
* skip connection.free in case when connection is not initialized

* Adding Interface for EventHubClient class to enable mock testing

* add no-arg constructors for GSon serialized types (#112)


# Conflicts:
#	azure-eventhubs-eph/src/main/java/com/microsoft/azure/eventprocessorhost/AzureBlobLease.java

* split platform & framework while adding to connection properties (#124)

* Update version to 0.14.2

* bump up the version to 0.15.0

* add receiver identifier to ReceiverOptions

* minor refactor

* client version to 0.14.3

* Refresh token every 10 mins - to help with error situations

* javadoc for receiveridentifier (#138)

* fix eph build issue after merge from master

* fix build break in eph after merge from master
SwayGom pushed a commit that referenced this pull request May 17, 2024
@SreeramGarlapati
Fix connectionImpl objects leak issue in scenarios when service close…
e353ab9 
…s connection (#116)

* free connectionImpl objects leak issue upon connection failures from service
* fix receive unit test
* skip connection.free in case when connection is not initialized
SwayGom pushed a commit that referenced this pull request May 17, 2024
@SreeramGarlapati
Fix connectionImpl objects leak issue in scenarios when service close…
0f357ad 
…s connection (#116)

* free connectionImpl objects leak issue upon connection failures from service
* fix receive unit test
* skip connection.free in case when connection is not initialized
SwayGom pushed a commit that referenced this pull request May 17, 2024
@SreeramGarlapati @sjkwak
Bring all changes from Master back to Dev (#140)
42aa5a9 
* Cherry-picking PR119 and PR122 into master (#129)

* Handle StorageExceptions from AzureBlobLease.isExpired

* Improve notification experience for ExecutionExceptions

* Cherry-pick PR119, start cherry-picking PR122

* Finish cherry-picking PR122

* Remove partial change that was picked accidentally

* Add Javadocs for PartitionManagerOptions (#130)

* Handle StorageExceptions from AzureBlobLease.isExpired

* Improve notification experience for ExecutionExceptions

* Cherry-pick PR119, start cherry-picking PR122

* Finish cherry-picking PR122

* Remove partial change that was picked accidentally

* Add Javadoc for PartitionManangerOptions

* Undo merge problem

* Set versions to 0.14.0 except eph 0.14.1

* Special override for EPH version

* Fix connectionImpl objects leak issue in scenarios when service closes connection (#116)

* free connectionImpl objects leak issue upon connection failures from service
* fix receive unit test
* skip connection.free in case when connection is not initialized

* Adding Interface for EventHubClient class to enable mock testing

* add no-arg constructors for GSon serialized types (#112)


# Conflicts:
#	azure-eventhubs-eph/src/main/java/com/microsoft/azure/eventprocessorhost/AzureBlobLease.java

* split platform & framework while adding to connection properties (#124)

* Update version to 0.14.2

* bump up the version to 0.15.0

* add receiver identifier to ReceiverOptions

* minor refactor

* client version to 0.14.3

* Refresh token every 10 mins - to help with error situations

* javadoc for receiveridentifier (#138)
SwayGom pushed a commit that referenced this pull request May 17, 2024
@SreeramGarlapati @sjkwak
fix build break in eph due to merge from master (#141)
1d63490 
* Cherry-picking PR119 and PR122 into master (#129)

* Handle StorageExceptions from AzureBlobLease.isExpired

* Improve notification experience for ExecutionExceptions

* Cherry-pick PR119, start cherry-picking PR122

* Finish cherry-picking PR122

* Remove partial change that was picked accidentally

* Add Javadocs for PartitionManagerOptions (#130)

* Handle StorageExceptions from AzureBlobLease.isExpired

* Improve notification experience for ExecutionExceptions

* Cherry-pick PR119, start cherry-picking PR122

* Finish cherry-picking PR122

* Remove partial change that was picked accidentally

* Add Javadoc for PartitionManangerOptions

* Undo merge problem

* Set versions to 0.14.0 except eph 0.14.1

* Special override for EPH version

* Fix connectionImpl objects leak issue in scenarios when service closes connection (#116)

* free connectionImpl objects leak issue upon connection failures from service
* fix receive unit test
* skip connection.free in case when connection is not initialized

* Adding Interface for EventHubClient class to enable mock testing

* add no-arg constructors for GSon serialized types (#112)


# Conflicts:
#	azure-eventhubs-eph/src/main/java/com/microsoft/azure/eventprocessorhost/AzureBlobLease.java

* split platform & framework while adding to connection properties (#124)

* Update version to 0.14.2

* bump up the version to 0.15.0

* add receiver identifier to ReceiverOptions

* minor refactor

* client version to 0.14.3

* Refresh token every 10 mins - to help with error situations

* javadoc for receiveridentifier (#138)

* fix eph build issue after merge from master

* fix build break in eph after merge from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesBirdsall JamesBirdsall JamesBirdsall approved these changes

@sjkwak sjkwak Awaiting requested review from sjkwak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.2
Development

Successfully merging this pull request may close these issues.
3 participants
@SreeramGarlapati @JamesBirdsall @msftclas