-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Key Vault references in Bicep and JSON parameter files #4744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I really appreciate how clean these changes were. It really helped highlight to me the idea of how much of azd
interpreting bicepparam / ARM files are really "passthrough changes to the ARM control plane".
I also really like that the existing code allowed us to add this change simply without affecting how param prompting works in azd.
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just adding a question about if we should be parsing the key vault reference or not.
Fixes #4706
This PR adds support for Key Vault references in parameter files, so you can now define a
param
inmain.bicep
that has a key vault reference (instead of a simple value) inmain.bicepparam
ormain.parameters.json
.The issue was that when deserializing the
main.parameters.json
file, the model type used did not have the necessary fields for key vault references. As a result, theValue
field would benil
and causeazd
to prompt the user for a value, ignoring the value in the Key Vault secret.Example
main.bicep:
main.bicepparam:
main.parameters.json:
Validation
Tested
azd up
on sample code that uses Bicep and JSON parameter files with KV references and confirmed that the secret value flowed through to the deployment output.Also tested with
alpha.deployment.stacks
set toon
andoff
.