-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Redis AVM's secretsExportConfiguration
param to store secrets in Key Vault
#4719
Use Redis AVM's secretsExportConfiguration
param to store secrets in Key Vault
#4719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the clean change.
FYI @JeffreyCA, I'm not sure if it's helpful but the tests in scaffold_test.go
does validate the Bicep syntax of the resulting generation. I also logged #4720 for us to move this up a layer where we can have azure.yaml
test cases as input, and add scenario tests that way.
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the clean change.
FYI @JeffreyCA, I'm not sure if it's helpful but the tests in
scaffold_test.go
does validate the Bicep syntax of the resulting generation. I also logged #4720 for us to move this up a layer where we can haveazure.yaml
test cases as input, and add scenario tests that way.
Thanks, that's good to know
Closes #4681
v0.9.0 of the Redis AVM adds support for
secretsExportConfiguration
, a standardized input param used by several other AVMs to export access keys and other secrets to Azure Key Vault after the resource has been provisioned. (Reference)This PR updates compose's Bicep generation to use the new module version and
secretsExportConfiguration
to write the Redis primary access key and connection string to Key Vault instead of our customset-redis-conn.bicep
Bicep module.Validation
Deployed a minimal Python Flask web app with Redis:
azure.yaml:
resources.bicep:
Python app code:
Key vault:
