[Hotfix] VectorIndexDefinition: Refactors Code to Remove Support for VectorIndexShardKey from Preview Contract
#4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dexShardKey` from Preview Contract (#4863) # Pull Request Template ## Description This PR removes support for `VectorIndexShardKey` from Preview Contract. ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] This change requires a documentation update ## Closing issues To automatically close an issue: closes #IssueNumber
This bumps the SDK GA version from `3.45.0` to `3.45.1` and preview version from `3.46.0-preview.0` to `3.46.0-preview.1`. No changes in the public GA contract. The preview contract changes are given below:  This version also bumps up the `Cosmos.Direct` package to `3.37.1`, which includes the below changes: - Currently Gateway is running into a `NullReferenceException` when hybrid query is supplied for execution. This is because for hybrid queries, `QueryInfo` in the plan is null (and instead `HybridSearchQueryInfo` is non-null). This is resulting in `500 (InternalServerError`) for JS SDK scenarios. The fix adds a `null` check for this. Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) To automatically close an issue: closes #IssueNumber
kundadebdatta
requested review from
a team,
kirankumarkolli,
FabianMeiswinkel,
sboshra and
Pilchie
as code owners
kirankumarkolli
previously approved these changes
Nov 8, 2024
kundadebdatta
requested review from
khdang,
adityasa,
neildsh and
kirillg
as code owners
adityasa
reviewed
Nov 10, 2024
...soft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/HybridSearchQueryTests.cs
Outdated
Show resolved
Hide resolved
|
Can we also enable FullText Indexing policy tests in ContainerSettingsTests.cs? |
…4868) This PR -Upgrades to the 3.37.1 version of the direct package -Adds additional testing on ORDER BY RANK RRF with VectorDistance in HybridSearchQueryTests SanityTests -Removes an unneeded (and problematic) check for unsupported features, which is not needed by the SDK. Previously, this code assumed there would always be a queryInfo object, however with hybrid search, this may not always be the case. But in addition, this check was not needed, so it is removed. Please delete options that are not relevant. - [] Bug fix (non-breaking change which fixes an issue) Co-Authored-By: Kiran Kumar Kolli <[email protected]>
Tests: Fixes Assert proper way
Emulator: Fixes upgrades to internal emulator Observations: - FFCF/AVAD: Emulator defaults resulting in 400/back request => Unblocking with `enablePreviousImageForDeleteInFFCF` override - ReadFeed with Binary now service returning in binary format (related tests upated) - Misc escaping changes - Emulator: Startup times seems regressed (will follow-up later) On FFCF part: There are two tests Updates -> Drains changes -> Deletes -> ChangeFeed => 400 Update + Deletes -> Changefeed -> Succeeded with 200 but no previous image Included `includeIdAndPKForDeletesInFFCFResponse` override working for both scenarios.
…s pipeline to use internal emulator. (#4875) ## Description This PR modified the emulator setup to use the internal emulator build, and sets queryEnableFullText to true so that we can test full text search It also enables some full-text-search-related tests --------- Co-authored-by: Kiran Kumar Kolli <[email protected]>
kundadebdatta
force-pushed
the
hotfix/3.45.1
branch
from
7eef163 to
4274757
Compare
kirankumarkolli
approved these changes
Nov 11, 2024
sc978345
approved these changes
Nov 11, 2024
microsoft-github-policy-service
bot
merged commit d41592f
into
releases/3.45.1
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
VectorIndexShardKeyfrom Preview Contract.nullcheck forHybridSearchQueryInfo.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber